Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

Also remove PolicyTest.DisableSpdy and
SpdyNetworkTransactionTest.SpdyOnOffToggle tests.

Also mark DisableSpdy policy deprecated.

This should mean no functional change, because DisableSpdy only acts
on the SPDY/3.1 protocol (since https://crrev.com/2150773003),
which is disabled entirely anyway (since https://crrev.com/2115213002).

BUG=624095
Committed: https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928
Cr-Commit-Position: refs/heads/master@{#406848}

[Bence, 2016-07-11 18:40:09]

Description was changed from

==========
Remove kDisableSpdy policy.

* Remove key::kDisableSpdy.
* Remove PolicyTest.DisableSpdy and SpdyNetworkTransactionTest.SpdyOnOffToggle.
* Remove class NetPrefObserver, the sole purpose of which was to observe
* kDisableSpdy changes and call HttpStreamFactory::set_spdy_enabled().
* Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

BUG=624095
==========

to

==========
Remove kDisableSpdy policy.

* Remove key::kDisableSpdy.
* Remove PolicyTest.DisableSpdy and SpdyNetworkTransactionTest.SpdyOnOffToggle.
* Remove class NetPrefObserver, the sole purpose of which was to observe
  kDisableSpdy changes and call HttpStreamFactory::set_spdy_enabled().
* Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

BUG=624095
==========

[Bence, 2016-07-12 17:25:06]

Description was changed from

==========
Remove kDisableSpdy policy.

* Remove key::kDisableSpdy.
* Remove PolicyTest.DisableSpdy and SpdyNetworkTransactionTest.SpdyOnOffToggle.
* Remove class NetPrefObserver, the sole purpose of which was to observe
  kDisableSpdy changes and call HttpStreamFactory::set_spdy_enabled().
* Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

BUG=624095
==========

to

==========
Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

Also remove PolicyTest.DisableSpdy and
SpdyNetworkTransactionTest.SpdyOnOffToggle.

Also mark DisableSpdy policy deprecated.

BUG=624095
==========

[Bence, 2016-07-12 21:00:00]

bnc@chromium.org changed reviewers:
+ mef@chromium.org, pastarmovj@chromium.org

[Bence, 2016-07-12 21:00:01]

mef: PTAL at chrome/browser/net/ and at net/

[Bence, 2016-07-12 21:02:07]

pastarmovj: PTAL at chrome/browser/policy/ and components/policy/

Thank you.

This CL will be followed by another one to remove DisableSpdy preference, and
possibly NetPrefObserver altogether.  I decided to break it up into two CLs
because I was struggling a bit with getting the policy removal right.

[pastarmovj, 2016-07-13 13:24:31]

policy lgtm

[mef, 2016-07-13 18:26:33]

I apologize for not being familiar with this, but it seems that in some places
using_spdy and spdy_enabled also mean using_h2 and h2_enabled. 

Is it expected? 
Do we have an ability to turn off H2 through policy?

https://codereview.chromium.org/2140733002/diff/100001/chrome/browser/net/net...
File chrome/browser/net/net_pref_observer.cc (right):

https://codereview.chromium.org/2140733002/diff/100001/chrome/browser/net/net...
chrome/browser/net/net_pref_observer.cc:33:
registry->RegisterBooleanPref(prefs::kDisableSpdy, false);
is this still needed?

https://codereview.chromium.org/2140733002/diff/100001/chrome/common/pref_nam...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/2140733002/diff/100001/chrome/common/pref_nam...
chrome/common/pref_names.cc:437: // DEPRECATED: SPDY/3.1 is not supported any
more.
Is there a separate setting to disable Http/2, or is it always on?

https://codereview.chromium.org/2140733002/diff/100001/net/http/http_stream_f...
File net/http/http_stream_factory_impl_job.cc (right):

https://codereview.chromium.org/2140733002/diff/100001/net/http/http_stream_f...
net/http/http_stream_factory_impl_job.cc:1611: using_spdy_ = true;
Does using_spdy_ mean using_h2 now?

https://codereview.chromium.org/2140733002/diff/100001/net/http/http_stream_f...
File net/http/http_stream_factory_impl_job_controller.cc (left):

https://codereview.chromium.org/2140733002/diff/100001/net/http/http_stream_f...
net/http/http_stream_factory_impl_job_controller.cc:753: if
(!HttpStreamFactory::spdy_enabled())
It seems that this flag is used to control both spdy31 and h2. Do we really want
to remove it?

[Bence, 2016-07-15 18:25:16]

Description was changed from

==========
Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

Also remove PolicyTest.DisableSpdy and
SpdyNetworkTransactionTest.SpdyOnOffToggle.

Also mark DisableSpdy policy deprecated.

BUG=624095
==========

to

==========
Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

Also remove PolicyTest.DisableSpdy and
SpdyNetworkTransactionTest.SpdyOnOffToggle tests.

Also mark DisableSpdy policy deprecated.

This should mean no functional change, because DisableSpdy only acts
on the SPDY/3.1 protocol (since https://crrev.com/2150773003),
which is disabled entirely anyway (since https://crrev.com/2115213002).

BUG=624095
==========

[Bence, 2016-07-15 18:39:40]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 18:40:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 20:33:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 20:33:16]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-07-15 20:35:33]

mef: PTAL.  Thank you for catching the bug about disabling/not disabling HTTP/2.
 We addressed it separately at https://crrev.com/2150773003, and I rebased this
CL on top of that one, so now this CL really is only about what its description
states.

https://codereview.chromium.org/2140733002/diff/100001/chrome/browser/net/net...
File chrome/browser/net/net_pref_observer.cc (right):

https://codereview.chromium.org/2140733002/diff/100001/chrome/browser/net/net...
chrome/browser/net/net_pref_observer.cc:33:
registry->RegisterBooleanPref(prefs::kDisableSpdy, false);
On 2016/07/13 18:26:32, mef wrote:
> is this still needed?

I would love to remove this, but then some policy tests complain about
unregistered prefs.  Note that kNetworkPredictionEnabled has been a noop for
more than a year now, and is still registered by this class.

I was experimenting a bit with removing the pref altogether, but it's not
trivial, so I decided to dedicate this CL to the functional change, and to
remove the policy in a follow-up CL.

https://codereview.chromium.org/2140733002/diff/100001/chrome/common/pref_nam...
File chrome/common/pref_names.cc (right):

https://codereview.chromium.org/2140733002/diff/100001/chrome/common/pref_nam...
chrome/common/pref_names.cc:437: // DEPRECATED: SPDY/3.1 is not supported any
more.
On 2016/07/13 18:26:32, mef wrote:
> Is there a separate setting to disable Http/2, or is it always on?

There is no enterprice policy to disable HTTP/2.  The reason is that HTTP/2 is
not an experimental feature: the RFC has been published more than a year ago,
and it is widely used.

This policy existed because SPDY was an experimental protocol.

https://codereview.chromium.org/2140733002/diff/100001/net/http/http_stream_f...
File net/http/http_stream_factory_impl_job.cc (right):

https://codereview.chromium.org/2140733002/diff/100001/net/http/http_stream_f...
net/http/http_stream_factory_impl_job.cc:1611: using_spdy_ = true;
On 2016/07/13 18:26:32, mef wrote:
> Does using_spdy_ mean using_h2 now?

Yes, it does.  Usually "spdy" in the codebase means "either SPDY/3.1 or HTTP/2".
 A mass rename of classes, members, methods, filenames etc. might happen in the
future.

https://codereview.chromium.org/2140733002/diff/100001/net/http/http_stream_f...
File net/http/http_stream_factory_impl_job_controller.cc (left):

https://codereview.chromium.org/2140733002/diff/100001/net/http/http_stream_f...
net/http/http_stream_factory_impl_job_controller.cc:753: if
(!HttpStreamFactory::spdy_enabled())
On 2016/07/13 18:26:32, mef wrote:
> It seems that this flag is used to control both spdy31 and h2. Do we really
want
> to remove it?

Ugh, good catch.  This was definitely not my intention.  I addressed it
separately at https://crrev.com/2150773003 and rebased this CL on that one.  I
am sorry for the oversight.

[Bence, 2016-07-19 17:51:18]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 17:51:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 19:05:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 19:05:38]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-07-19 19:11:56]

mef: ping.

[mef, 2016-07-20 20:15:38]

lgtm

https://codereview.chromium.org/2140733002/diff/140001/chrome/browser/net/net...
File chrome/browser/net/net_pref_observer.cc (right):

https://codereview.chromium.org/2140733002/diff/140001/chrome/browser/net/net...
chrome/browser/net/net_pref_observer.cc:33:
registry->RegisterBooleanPref(prefs::kDisableSpdy, false);
maybe add a comment why it has to be here despite not doing anything.

[Bence, 2016-07-21 00:37:42]

The CQ bit was checked by bnc@chromium.org

[Bence, 2016-07-21 00:37:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
pastarmovj@chromium.org
Link to the patchset: https://codereview.chromium.org/2140733002/#ps140001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-07-21 00:38:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2016-07-21 00:39:10]

Thank you both.

https://codereview.chromium.org/2140733002/diff/140001/chrome/browser/net/net...
File chrome/browser/net/net_pref_observer.cc (right):

https://codereview.chromium.org/2140733002/diff/140001/chrome/browser/net/net...
chrome/browser/net/net_pref_observer.cc:33:
registry->RegisterBooleanPref(prefs::kDisableSpdy, false);
On 2016/07/20 20:15:38, mef wrote:
> maybe add a comment why it has to be here despite not doing anything.

I plan to remove this class very soon, so I hope it's not necessary to add a
comment.

[commit-bot: I haz the power, 2016-07-21 00:40:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 00:40:37]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Bence, 2016-07-21 12:07:02]

The CQ bit was checked by bnc@chromium.org

[Bence, 2016-07-21 12:07:03]

The patchset sent to the CQ was uploaded after l-g-t-m from mef@chromium.org,
pastarmovj@chromium.org
Link to the patchset: https://codereview.chromium.org/2140733002/#ps160001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-07-21 12:07:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 13:12:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 13:12:34]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Bence, 2016-07-21 14:03:56]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-07-21 14:04:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 14:46:13]

Description was changed from

==========
Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

Also remove PolicyTest.DisableSpdy and
SpdyNetworkTransactionTest.SpdyOnOffToggle tests.

Also mark DisableSpdy policy deprecated.

This should mean no functional change, because DisableSpdy only acts
on the SPDY/3.1 protocol (since https://crrev.com/2150773003),
which is disabled entirely anyway (since https://crrev.com/2115213002).

BUG=624095
==========

to

==========
Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

Also remove PolicyTest.DisableSpdy and
SpdyNetworkTransactionTest.SpdyOnOffToggle tests.

Also mark DisableSpdy policy deprecated.

This should mean no functional change, because DisableSpdy only acts
on the SPDY/3.1 protocol (since https://crrev.com/2150773003),
which is disabled entirely anyway (since https://crrev.com/2115213002).

BUG=624095
==========

[commit-bot: I haz the power, 2016-07-21 14:46:15]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-07-21 14:48:10]

Description was changed from

==========
Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

Also remove PolicyTest.DisableSpdy and
SpdyNetworkTransactionTest.SpdyOnOffToggle tests.

Also mark DisableSpdy policy deprecated.

This should mean no functional change, because DisableSpdy only acts
on the SPDY/3.1 protocol (since https://crrev.com/2150773003),
which is disabled entirely anyway (since https://crrev.com/2115213002).

BUG=624095
==========

to

==========
Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

Also remove PolicyTest.DisableSpdy and
SpdyNetworkTransactionTest.SpdyOnOffToggle tests.

Also mark DisableSpdy policy deprecated.

This should mean no functional change, because DisableSpdy only acts
on the SPDY/3.1 protocol (since https://crrev.com/2150773003),
which is disabled entirely anyway (since https://crrev.com/2115213002).

BUG=624095

Committed: https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928
Cr-Commit-Position: refs/heads/master@{#406848}
==========

[commit-bot: I haz the power, 2016-07-21 14:48:13]

Patchset 9 (id:??) landed as
https://crrev.com/927c496c6cea4ed5f1c96ed14abdea9961749928
Cr-Commit-Position: refs/heads/master@{#406848}