Remove HttpStreamFactory::spdy_enabled_ static member and accessors.

chrome/browser/net/net_pref_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/net/net_pref_observer.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "chrome/common/pref_names.h"
 #include "components/pref_registry/pref_registry_syncable.h"
 #include "components/prefs/pref_service.h"
 #include "content/public/browser/browser_thread.h"
 #include "net/http/http_stream_factory.h"
 
 using content::BrowserThread;
 
 NetPrefObserver::NetPrefObserver(PrefService* prefs) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
   DCHECK(prefs);
-
-  base::Closure prefs_callback = base::Bind(&NetPrefObserver::ApplySettings,
-                                            base::Unretained(this));
-  spdy_disabled_.Init(prefs::kDisableSpdy, prefs, prefs_callback);
-
-  ApplySettings();
 }
 
 NetPrefObserver::~NetPrefObserver() {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 }
 
-void NetPrefObserver::ApplySettings() {
-  DCHECK_CURRENTLY_ON(BrowserThread::UI);
-
-  if (spdy_disabled_.IsManaged())
-    net::HttpStreamFactory::set_spdy_enabled(!*spdy_disabled_);
-}
-
 // static
 void NetPrefObserver::RegisterProfilePrefs(
     user_prefs::PrefRegistrySyncable* registry) {
   registry->RegisterBooleanPref(
       prefs::kNetworkPredictionEnabled,
       true,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
   registry->RegisterBooleanPref(prefs::kDisableSpdy, false);

[mef, 2016/07/13 18:26:32]

is this still needed?

[Bence, 2016/07/15 20:35:33]

I would love to remove this, but then some policy tests complain about
unregistered prefs.  Note that kNetworkPredictionEnabled has been a noop for
more than a year now, and is still registered by this class.

I was experimenting a bit with removing the pref altogether, but it's not
trivial, so I decided to dedicate this CL to the functional change, and to
remove the policy in a follow-up CL.

 }