Issue 2140723002: Fix a logic bug in kqueue.c.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2140723002: Fix a logic bug in kqueue.c. (Closed)

Created:
4 years, 5 months ago by erikchen

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

Fix a logic bug in kqueue.c. Remove an unnecessary workaround for OS X 10.4 from kqueue.c. It was causing problems on macOS Sierra. All credit for this CL goes to mark@chromium.org. BUG=626534, 620259 Review-Url: https://codereview.chromium.org/2134603002 Cr-Commit-Position: refs/heads/master@{#404421} (cherry picked from commit 3b07cd446f6bf33618ebae11ca68273b7a0de2f8) Committed: https://chromium.googlesource.com/chromium/src/+/45a5e0217612dfb48e8c3fd5dcd7e186d8288c52

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -22 lines)			Patch
	M	base/third_party/libevent/README.chromium	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	base/third_party/libevent/kqueue.c	View		1 chunk	+0 lines, -22 lines	0 comments	Download

Total messages: 2 (1 generated)

erikchen

4 years, 5 months ago (2016-07-11 17:27:30 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
45a5e0217612dfb48e8c3fd5dcd7e186d8288c52.