Fix a logic bug in kqueue.c.

Fix a logic bug in kqueue.c.

Remove an unnecessary workaround for OS X 10.4 from kqueue.c. It was causing
problems on macOS Sierra.

All credit for this CL goes to mark@chromium.org.

BUG=626534, 620259
Committed: https://crrev.com/3b07cd446f6bf33618ebae11ca68273b7a0de2f8
Cr-Commit-Position: refs/heads/master@{#404421}

[erikchen, 2016-07-08 05:37:34]

erikchen@chromium.org changed reviewers:
+ mark@chromium.org

[erikchen, 2016-07-08 05:37:34]

mark: Please review.

[Mark Mentovai, 2016-07-08 11:15:02]

LGTM. Thanks for taking this idea for a spin!

https://codereview.chromium.org/2134603002/diff/1/base/third_party/libevent/R...
File base/third_party/libevent/README.chromium (right):

https://codereview.chromium.org/2134603002/diff/1/base/third_party/libevent/R...
base/third_party/libevent/README.chromium:1: Name: libevent
CL description: since this also fixes bug 620259, add that to the BUG line.

https://codereview.chromium.org/2134603002/diff/1/base/third_party/libevent/k...
File base/third_party/libevent/kqueue.c (right):

https://codereview.chromium.org/2134603002/diff/1/base/third_party/libevent/k...
base/third_party/libevent/kqueue.c:143: /* Check for Mac OS X kqueue bug. */
Since we’ve already got a bunch of local modifications, I’d be just as inclined
to remove this section altogether. It tests for a 10.4 bug that was fixed in
10.5, so it’s just bloat as far as we’re concerned.

[erikchen, 2016-07-08 15:17:48]

Description was changed from

==========
Fix a logic bug in kqueue.c.

The parameter struct kevent::flags was being directly compared against EV_ERROR
rather than using a bit mask.

All credit for this CL goes to mark@chromium.org.

BUG=626534
==========

to

==========
Fix a logic bug in kqueue.c.

The parameter struct kevent::flags was being directly compared against EV_ERROR
rather than using a bit mask.

All credit for this CL goes to mark@chromium.org.

BUG=626534, 620259
==========

[erikchen, 2016-07-08 15:19:17]

Description was changed from

==========
Fix a logic bug in kqueue.c.

The parameter struct kevent::flags was being directly compared against EV_ERROR
rather than using a bit mask.

All credit for this CL goes to mark@chromium.org.

BUG=626534, 620259
==========

to

==========
Fix a logic bug in kqueue.c.

Remove an unnecessary workaround for OS X 10.4 from kqueue.c. It was causing
problems on macOS Sierra.

All credit for this CL goes to mark@chromium.org.

BUG=626534, 620259
==========

[erikchen, 2016-07-08 15:20:06]

PTAL

https://codereview.chromium.org/2134603002/diff/1/base/third_party/libevent/R...
File base/third_party/libevent/README.chromium (right):

https://codereview.chromium.org/2134603002/diff/1/base/third_party/libevent/R...
base/third_party/libevent/README.chromium:1: Name: libevent
On 2016/07/08 11:15:02, Mark Mentovai wrote:
> CL description: since this also fixes bug 620259, add that to the BUG line.

Done.

https://codereview.chromium.org/2134603002/diff/1/base/third_party/libevent/k...
File base/third_party/libevent/kqueue.c (right):

https://codereview.chromium.org/2134603002/diff/1/base/third_party/libevent/k...
base/third_party/libevent/kqueue.c:143: /* Check for Mac OS X kqueue bug. */
On 2016/07/08 11:15:02, Mark Mentovai wrote:
> Since we’ve already got a bunch of local modifications, I’d be just as
inclined
> to remove this section altogether. It tests for a 10.4 bug that was fixed in
> 10.5, so it’s just bloat as far as we’re concerned.

Done.

[Mark Mentovai, 2016-07-08 16:04:12]

LGTM!

[erikchen, 2016-07-08 16:06:23]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-07-08 16:06:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-08 17:06:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-08 17:06:37]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-08 17:08:52]

Description was changed from

==========
Fix a logic bug in kqueue.c.

Remove an unnecessary workaround for OS X 10.4 from kqueue.c. It was causing
problems on macOS Sierra.

All credit for this CL goes to mark@chromium.org.

BUG=626534, 620259
==========

to

==========
Fix a logic bug in kqueue.c.

Remove an unnecessary workaround for OS X 10.4 from kqueue.c. It was causing
problems on macOS Sierra.

All credit for this CL goes to mark@chromium.org.

BUG=626534, 620259

Committed: https://crrev.com/3b07cd446f6bf33618ebae11ca68273b7a0de2f8
Cr-Commit-Position: refs/heads/master@{#404421}
==========

[commit-bot: I haz the power, 2016-07-08 17:08:53]

Patchset 2 (id:??) landed as
https://crrev.com/3b07cd446f6bf33618ebae11ca68273b7a0de2f8
Cr-Commit-Position: refs/heads/master@{#404421}