Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop

Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop

A fewer crashers on QuicHttpStream::DoReadRequestBody
indicate that QuicHttpStream might be destroyed in
the middle of DoLoop. The crashers are pretty rare. This CL
adds a bool so that if QuicHttpStream gets destroyed during
DoLoop, we will get the call stack which will tell us how
it is being destroyed.

BUG=627099
Committed: https://crrev.com/1f48e6ebda2ca94af20d049aff0863244232ffc5
Cr-Commit-Position: refs/heads/master@{#405328}

[xunjieli, 2016-07-13 13:33:01]

Description was changed from

==========
Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop

BUG=
==========

to

==========
Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop

A fewer minidumps on Windows which crash on 
QuicHttpStream::DoReadRequestBody indicate that 
QuicHttpStream might be destroyed in the middle of DoLoop. 
The crashers are pretty rare. This CL adds a bool so that
if QuicHttpStream gets destroyed during DoLoop, we will
get the call stack which will tell us how it is being
destroyed.

BUG=627099
==========

[xunjieli, 2016-07-13 13:34:36]

Description was changed from

==========
Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop

A fewer minidumps on Windows which crash on 
QuicHttpStream::DoReadRequestBody indicate that 
QuicHttpStream might be destroyed in the middle of DoLoop. 
The crashers are pretty rare. This CL adds a bool so that
if QuicHttpStream gets destroyed during DoLoop, we will
get the call stack which will tell us how it is being
destroyed.

BUG=627099
==========

to

==========
Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop

A fewer crashers on QuicHttpStream::DoReadRequestBody 
indicate indicate that QuicHttpStream might be destroyed in 
the middle of DoLoop. The crashers are pretty rare. This CL 
adds a bool so that if QuicHttpStream gets destroyed during 
DoLoop, we will get the call stack which will tell us how it is being destroyed.

BUG=627099
==========

[xunjieli, 2016-07-13 13:38:02]

Patchset #1 (id:1) has been deleted

[xunjieli, 2016-07-13 13:38:22]

Description was changed from

==========
Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop

A fewer crashers on QuicHttpStream::DoReadRequestBody 
indicate indicate that QuicHttpStream might be destroyed in 
the middle of DoLoop. The crashers are pretty rare. This CL 
adds a bool so that if QuicHttpStream gets destroyed during 
DoLoop, we will get the call stack which will tell us how it is being destroyed.

BUG=627099
==========

to

==========
Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop

A fewer crashers on QuicHttpStream::DoReadRequestBody 
indicate indicate that QuicHttpStream might be destroyed in 
the middle of DoLoop. The crashers are pretty rare. This CL 
adds a bool so that if QuicHttpStream gets destroyed during 
DoLoop, we will get the call stack which will tell us how 
it is being destroyed.

BUG=627099
==========

[xunjieli, 2016-07-13 13:43:28]

xunjieli@chromium.org changed reviewers:
+ rch@chromium.org

[xunjieli, 2016-07-13 13:43:28]

Hi Ryan:

Matt helped me with investigating crbug.com/627099, a QuicHttpStream crasher on
cronet. We looked at a fewer Windows crashers on M50 and M51 which have
QuicHttpStream::DoReadRequestBody. The minidumps indicate that QuicHttpStream
might be destroyed while executing the DoLoop. There might be an re-entrancy
issue somewhere. I added some CHECKs so we can get more information. Could you
take a look?

Thanks!

[xunjieli, 2016-07-13 21:03:51]

Description was changed from

==========
Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop

A fewer crashers on QuicHttpStream::DoReadRequestBody 
indicate indicate that QuicHttpStream might be destroyed in 
the middle of DoLoop. The crashers are pretty rare. This CL 
adds a bool so that if QuicHttpStream gets destroyed during 
DoLoop, we will get the call stack which will tell us how 
it is being destroyed.

BUG=627099
==========

to

==========
Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop

A fewer crashers on QuicHttpStream::DoReadRequestBody 
indicate that QuicHttpStream might be destroyed in 
the middle of DoLoop. The crashers are pretty rare. This CL 
adds a bool so that if QuicHttpStream gets destroyed during 
DoLoop, we will get the call stack which will tell us how 
it is being destroyed.

BUG=627099
==========

[Ryan Hamilton, 2016-07-13 21:04:27]

lgtm

I'm curious to see what the crash reports will show!

[Ryan Hamilton, 2016-07-13 21:04:31]

The CQ bit was checked by rch@chromium.org

[commit-bot: I haz the power, 2016-07-13 21:05:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 22:53:17]

Description was changed from

==========
Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop

A fewer crashers on QuicHttpStream::DoReadRequestBody 
indicate that QuicHttpStream might be destroyed in 
the middle of DoLoop. The crashers are pretty rare. This CL 
adds a bool so that if QuicHttpStream gets destroyed during 
DoLoop, we will get the call stack which will tell us how 
it is being destroyed.

BUG=627099
==========

to

==========
Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop

A fewer crashers on QuicHttpStream::DoReadRequestBody 
indicate that QuicHttpStream might be destroyed in 
the middle of DoLoop. The crashers are pretty rare. This CL 
adds a bool so that if QuicHttpStream gets destroyed during 
DoLoop, we will get the call stack which will tell us how 
it is being destroyed.

BUG=627099
==========

[commit-bot: I haz the power, 2016-07-13 22:53:18]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-07-13 22:53:23]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 22:54:37]

Description was changed from

==========
Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop

A fewer crashers on QuicHttpStream::DoReadRequestBody 
indicate that QuicHttpStream might be destroyed in 
the middle of DoLoop. The crashers are pretty rare. This CL 
adds a bool so that if QuicHttpStream gets destroyed during 
DoLoop, we will get the call stack which will tell us how 
it is being destroyed.

BUG=627099
==========

to

==========
Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop

A fewer crashers on QuicHttpStream::DoReadRequestBody
indicate that QuicHttpStream might be destroyed in
the middle of DoLoop. The crashers are pretty rare. This CL
adds a bool so that if QuicHttpStream gets destroyed during
DoLoop, we will get the call stack which will tell us how
it is being destroyed.

BUG=627099

Committed: https://crrev.com/1f48e6ebda2ca94af20d049aff0863244232ffc5
Cr-Commit-Position: refs/heads/master@{#405328}
==========

[commit-bot: I haz the power, 2016-07-13 22:54:38]

Patchset 1 (id:??) landed as
https://crrev.com/1f48e6ebda2ca94af20d049aff0863244232ffc5
Cr-Commit-Position: refs/heads/master@{#405328}