Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: net/quic/quic_http_stream.h

Issue 2140673006: Add CHECK to make sure QuicHttpStream does not get destroyed during DoLoop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/quic_http_stream.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef NET_QUIC_QUIC_HTTP_STREAM_H_ 5 #ifndef NET_QUIC_QUIC_HTTP_STREAM_H_
6 #define NET_QUIC_QUIC_HTTP_STREAM_H_ 6 #define NET_QUIC_QUIC_HTTP_STREAM_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
200 // True when this stream receives a go away from server due to port migration. 200 // True when this stream receives a go away from server due to port migration.
201 bool port_migration_detected_; 201 bool port_migration_detected_;
202 202
203 bool found_promise_; 203 bool found_promise_;
204 // |QuicClientPromisedInfo| owns this. It will be set when |Try()| 204 // |QuicClientPromisedInfo| owns this. It will be set when |Try()|
205 // is asynchronous, i.e. it returned QUIC_PENDING, and remains valid 205 // is asynchronous, i.e. it returned QUIC_PENDING, and remains valid
206 // until |OnRendezvouResult()| fires or |push_handle_->Cancel()| is 206 // until |OnRendezvouResult()| fires or |push_handle_->Cancel()| is
207 // invoked. 207 // invoked.
208 QuicClientPushPromiseIndex::TryHandle* push_handle_; 208 QuicClientPushPromiseIndex::TryHandle* push_handle_;
209 209
210 // Set to true when DoLoop() is being executed, false otherwise.
211 bool in_loop_;
212
210 base::WeakPtrFactory<QuicHttpStream> weak_factory_; 213 base::WeakPtrFactory<QuicHttpStream> weak_factory_;
211 214
212 DISALLOW_COPY_AND_ASSIGN(QuicHttpStream); 215 DISALLOW_COPY_AND_ASSIGN(QuicHttpStream);
213 }; 216 };
214 217
215 } // namespace net 218 } // namespace net
216 219
217 #endif // NET_QUIC_QUIC_HTTP_STREAM_H_ 220 #endif // NET_QUIC_QUIC_HTTP_STREAM_H_
OLDNEW
« no previous file with comments | « no previous file | net/quic/quic_http_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698