Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2140673002: Remove SPDY/3.1 tests. (Closed)

Created:
4 years, 5 months ago by Bence
Modified:
4 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SPDY/3.1 tests. * Remove SPDY/3.1 test cases. * s/TEST_P/TEST_F/ where there are no remaining test parameters. * Remove SPDY/3.1-only tests. * Remove protocol version arguments, members, accessors from test helper functions and classes. * Hardwire kProtoHTTP2 or HTTP2 in SpdyFramer, BufferedSpdyFramer constructors, other function calls. (Some of these arguments will be removed in follow-up CLs.) * Remove SSLClientSocketTest.NPNNoOverlap and NPNServerPreference, because they are moot if HTTP/2 is the only non-trivial NPN protocol supported. Note that NPN has been disabled anyway. * Remove SPDY/3.1-specific MaybAddVersionHeader(), GetVersionKey(). * Remove unused HttpProxyClientSocketPoolTestParams default constructor. * Inline UpdateSpdySessionDependencies. BUG=624095 Committed: https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c Cr-Commit-Position: refs/heads/master@{#404718}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+525 lines, -1535 lines) Patch
M net/http/bidirectional_stream_unittest.cc View 6 chunks +6 lines, -7 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 67 chunks +74 lines, -114 lines 0 comments Download
M net/http/http_proxy_client_socket_pool_unittest.cc View 6 chunks +9 lines, -25 lines 0 comments Download
M net/http/http_stream_factory_impl_job_controller_unittest.cc View 8 chunks +8 lines, -12 lines 0 comments Download
M net/http/http_stream_factory_impl_request_unittest.cc View 2 chunks +5 lines, -14 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 31 chunks +52 lines, -73 lines 0 comments Download
M net/socket/ssl_client_socket_pool_unittest.cc View 26 chunks +33 lines, -38 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 3 chunks +5 lines, -52 lines 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 10 chunks +21 lines, -99 lines 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 11 chunks +15 lines, -26 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 55 chunks +72 lines, -519 lines 0 comments Download
M net/spdy/spdy_proxy_client_socket_unittest.cc View 5 chunks +10 lines, -29 lines 0 comments Download
M net/spdy/spdy_session_pool_unittest.cc View 8 chunks +10 lines, -17 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 42 chunks +90 lines, -251 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 6 chunks +9 lines, -23 lines 0 comments Download
M net/spdy/spdy_test_util_common.h View 10 chunks +12 lines, -31 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 28 chunks +92 lines, -202 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 5 months ago (2016-07-11 17:02:29 UTC) #2
Ryan Hamilton
lgtm
4 years, 5 months ago (2016-07-11 19:39:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140673002/1
4 years, 5 months ago (2016-07-11 20:05:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 20:10:59 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-11 20:11:04 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a9b9e22b06bb8a4279229820e770b5a6bd19388c Cr-Commit-Position: refs/heads/master@{#404718}
4 years, 5 months ago (2016-07-11 20:14:21 UTC) #9
Bence
4 years, 5 months ago (2016-07-11 20:41:07 UTC) #10
Message was sent while issue was closed.
For the record, this CL reduces the number of net_unittest cases from 23918 to
23208, that is, by 3%.

Powered by Google App Engine
This is Rietveld 408576698