Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: net/http/http_stream_factory_impl_request_unittest.cc

Issue 2140673002: Remove SPDY/3.1 tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_stream_factory_impl_request_unittest.cc
diff --git a/net/http/http_stream_factory_impl_request_unittest.cc b/net/http/http_stream_factory_impl_request_unittest.cc
index 1954d3b7daf2733723780ad932138275c7db4fb1..45abea2f1bc98aaf1c364ea68644575626cfc4d5 100644
--- a/net/http/http_stream_factory_impl_request_unittest.cc
+++ b/net/http/http_stream_factory_impl_request_unittest.cc
@@ -20,19 +20,11 @@ using testing::_;
namespace net {
-class HttpStreamFactoryImplRequestTest
- : public ::testing::Test,
- public ::testing::WithParamInterface<NextProto> {};
-
-INSTANTIATE_TEST_CASE_P(NextProto,
- HttpStreamFactoryImplRequestTest,
- testing::Values(kProtoSPDY31,
- kProtoHTTP2));
+class HttpStreamFactoryImplRequestTest : public ::testing::Test {};
// Make sure that Request passes on its priority updates to its jobs.
-TEST_P(HttpStreamFactoryImplRequestTest, SetPriority) {
- SpdySessionDependencies session_deps(GetParam(),
- ProxyService::CreateDirect());
+TEST_F(HttpStreamFactoryImplRequestTest, SetPriority) {
+ SpdySessionDependencies session_deps(ProxyService::CreateDirect());
std::unique_ptr<HttpNetworkSession> session =
SpdySessionDependencies::SpdyCreateSession(&session_deps);
HttpStreamFactoryImpl* factory =
@@ -63,9 +55,8 @@ TEST_P(HttpStreamFactoryImplRequestTest, SetPriority) {
EXPECT_EQ(IDLE, job_controller->main_job()->priority());
}
-TEST_P(HttpStreamFactoryImplRequestTest, DelayMainJob) {
- SpdySessionDependencies session_deps(GetParam(),
- ProxyService::CreateDirect());
+TEST_F(HttpStreamFactoryImplRequestTest, DelayMainJob) {
+ SpdySessionDependencies session_deps(ProxyService::CreateDirect());
std::unique_ptr<HttpNetworkSession> session =
SpdySessionDependencies::SpdyCreateSession(&session_deps);
« no previous file with comments | « net/http/http_stream_factory_impl_job_controller_unittest.cc ('k') | net/http/http_stream_factory_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698