Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 2140563002: Revert of Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context (Closed)

Created:
4 years, 5 months ago by Jakob Kummerow
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context (patchset #2 id:20001 of https://codereview.chromium.org/2131483002/ ) Reason for revert: crashes: crbug.com/626719 Original issue's description: > Avoid Context::Enter and Context::Exit if we're reentering the active and last entered context > > A bit of browsing around indicates that the new fast-path is taken most of the time: > 3496 Entering new > 152295 Reentering same > > BUG= > > Committed: https://crrev.com/1829eb661ef1cf432fb551bcb193f521a219d490 > Cr-Commit-Position: refs/heads/master@{#37570} TBR=jochen@chromium.org,verwaest@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/bec49a4876fdf8a20600ecdfc8534d0ef45c9528 Cr-Commit-Position: refs/heads/master@{#37632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M src/api.cc View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Jakob Kummerow
Created Revert of Avoid Context::Enter and Context::Exit if we're reentering the active and last entered ...
4 years, 5 months ago (2016-07-11 10:01:49 UTC) #2
Camillo Bruni
4 years, 5 months ago (2016-07-14 16:26:19 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2152803003/ by cbruni@chromium.org.

The reason for reverting is: https://codereview.chromium.org/2122953002 fixed
context issues..

Powered by Google App Engine
This is Rietveld 408576698