Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1340)

Unified Diff: content/renderer/fetchers/resource_fetcher_impl.cc

Issue 2140523002: Remove WebURLRequest::initialize() and simplify WebURLRequest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/fetchers/resource_fetcher_impl.cc
diff --git a/content/renderer/fetchers/resource_fetcher_impl.cc b/content/renderer/fetchers/resource_fetcher_impl.cc
index 51878491e6a3403494189701d3ba69008ed89fe2..3c23271e2661e938a2dd456b1c196b659528f7ba 100644
--- a/content/renderer/fetchers/resource_fetcher_impl.cc
+++ b/content/renderer/fetchers/resource_fetcher_impl.cc
@@ -122,8 +122,8 @@ void ResourceFetcherImpl::Start(
}
loader_->loadAsynchronously(request_, this);
- // No need to hold on to the request.
- request_.reset();
+ // Reset the request.
+ request_.setURL(GURL());
dcheng 2016/07/11 09:47:50 It's a bit unexpected that this is the right way t
kinuko 2016/07/11 09:54:23 Yup you're right this change is probably not quite
kinuko 2016/07/12 04:19:57 Took the path to simply do request_ = WebURLReques
}
void ResourceFetcherImpl::SetTimeout(const base::TimeDelta& timeout) {

Powered by Google App Engine
This is Rietveld 408576698