Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2140383004: Disable embedded bitmap test on iOS. (Closed)

Created:
4 years, 5 months ago by bungeman-skia
Modified:
4 years, 5 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Disable embedded bitmap test on iOS. The TypefaceRenderingGM crashes on iOS when drawing an embedded bitmap when requesting aliased rendering. The crash looks like libTrueTypeScaler.dylib`<redacted> + 80 stop reason = EXC_BAD_ACCESS (code=EXC_ARM_DA_ALIGN, address=...) -> 0x330b19d0 <+80>: strd r2, r3, [r5, #36] 0x330b19d4 <+84>: movs r3, #0x0 0x330b19d6 <+86>: add r2, sp, #0x28 0x330b19d8 <+88>: ldr r0, [r4, #0x4] Disable testing embedded bitmaps on iOS for now. BUG=skia:5530 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2140383004 Committed: https://skia.googlesource.com/skia/+/82945560e61f2996d2749b74359d219f56c92dda

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M gm/typeface.cpp View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
bungeman-skia
4 years, 5 months ago (2016-07-13 17:07:28 UTC) #4
mtklein
https://codereview.chromium.org/2140383004/diff/1/gm/typeface.cpp File gm/typeface.cpp (right): https://codereview.chromium.org/2140383004/diff/1/gm/typeface.cpp#newcode197 gm/typeface.cpp:197: #ifdef SK_BUILD_FOR_IOS Note why, maybe skbug link?
4 years, 5 months ago (2016-07-13 17:11:17 UTC) #5
bungeman-skia
https://codereview.chromium.org/2140383004/diff/1/gm/typeface.cpp File gm/typeface.cpp (right): https://codereview.chromium.org/2140383004/diff/1/gm/typeface.cpp#newcode197 gm/typeface.cpp:197: #ifdef SK_BUILD_FOR_IOS On 2016/07/13 17:11:17, mtklein wrote: > Note ...
4 years, 5 months ago (2016-07-13 17:30:33 UTC) #9
mtklein
lgtm
4 years, 5 months ago (2016-07-13 17:37:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2140383004/20001
4 years, 5 months ago (2016-07-13 17:39:40 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 17:57:27 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/82945560e61f2996d2749b74359d219f56c92dda

Powered by Google App Engine
This is Rietveld 408576698