Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: gm/typeface.cpp

Issue 2140383004: Disable embedded bitmap test on iOS. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Add comment. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 Google Inc. 2 * Copyright 2012 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "gm.h" 8 #include "gm.h"
9 #include "Resources.h" 9 #include "Resources.h"
10 #include "SkCanvas.h" 10 #include "SkCanvas.h"
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 187
188 // The hintgasp.ttf is designed for the following sizes to be different. 188 // The hintgasp.ttf is designed for the following sizes to be different.
189 // GASP_DOGRAY 0x0002 0<=ppem<=10 189 // GASP_DOGRAY 0x0002 0<=ppem<=10
190 // GASP_SYMMETRIC_SMOOTHING 0x0008 0<=ppem<=10 190 // GASP_SYMMETRIC_SMOOTHING 0x0008 0<=ppem<=10
191 // GASP_GRIDFIT 0x0001 11<=ppem<=12 191 // GASP_GRIDFIT 0x0001 11<=ppem<=12
192 // GASP_SYMMETRIC_GRIDFIT 0x0004 11<=ppem<=12 192 // GASP_SYMMETRIC_GRIDFIT 0x0004 11<=ppem<=12
193 // GASP_DOGRAY|GASP_GRIDFIT 0x0003 13<=ppem<=14 193 // GASP_DOGRAY|GASP_GRIDFIT 0x0003 13<=ppem<=14
194 // GASP_SYMMETRIC_SMOOTHING|GASP_SYMMETRIC_GRIDFIT 0x000C 13<=ppem<=14 194 // GASP_SYMMETRIC_SMOOTHING|GASP_SYMMETRIC_GRIDFIT 0x000C 13<=ppem<=14
195 // (neither) 0x0000 15<=ppem 195 // (neither) 0x0000 15<=ppem
196 // Odd sizes have embedded bitmaps. 196 // Odd sizes have embedded bitmaps.
197 #ifdef SK_BUILD_FOR_IOS
198 // This gm crashes on iOS when drawing an embedded bitmap when requestin g aliased rendering.
199 // The crash looks like
200 // libTrueTypeScaler.dylib`<redacted> + 80
201 // stop reason = EXC_BAD_ACCESS (code=EXC_ARM_DA_ALIGN, address=...)
202 // -> 0x330b19d0 <+80>: strd r2, r3, [r5, #36]
203 // 0x330b19d4 <+84>: movs r3, #0x0
204 // 0x330b19d6 <+86>: add r2, sp, #0x28
205 // 0x330b19d8 <+88>: ldr r0, [r4, #0x4]
206 // Disable testing embedded bitmaps on iOS for now.
207 // See https://bug.skia.org/5530 .
208 constexpr SkScalar textSizes[] = { 10, 12, 14, 16 };
209 #else
197 constexpr SkScalar textSizes[] = { 9, 10, 11, 12, 13, 14, 15, 16 }; 210 constexpr SkScalar textSizes[] = { 9, 10, 11, 12, 13, 14, 15, 16 };
211 #endif
198 212
199 constexpr SkPaint::Hinting hintingTypes[] = { SkPaint::kNo_Hinting, 213 constexpr SkPaint::Hinting hintingTypes[] = { SkPaint::kNo_Hinting,
200 SkPaint::kSlight_Hinting, 214 SkPaint::kSlight_Hinting,
201 SkPaint::kNormal_Hinting, 215 SkPaint::kNormal_Hinting,
202 SkPaint::kFull_Hinting }; 216 SkPaint::kFull_Hinting };
203 217
204 struct SubpixelType { 218 struct SubpixelType {
205 bool requested; 219 bool requested;
206 SkVector offset; 220 SkVector offset;
207 } constexpr subpixelTypes[] = { 221 } constexpr subpixelTypes[] = {
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 279
266 private: 280 private:
267 typedef skiagm::GM INHERITED; 281 typedef skiagm::GM INHERITED;
268 }; 282 };
269 283
270 /////////////////////////////////////////////////////////////////////////////// 284 ///////////////////////////////////////////////////////////////////////////////
271 285
272 DEF_GM( return new TypefaceStylesGM(false); ) 286 DEF_GM( return new TypefaceStylesGM(false); )
273 DEF_GM( return new TypefaceStylesGM(true); ) 287 DEF_GM( return new TypefaceStylesGM(true); )
274 DEF_GM( return new TypefaceRenderingGM(); ) 288 DEF_GM( return new TypefaceRenderingGM(); )
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698