Move StringView constructors into WTFString.h/AtomicString.h

Move StringView constructors into WTFString.h/AtomicString.h

This will allow String and AtomicString to depend on StringView for
methods and arguments, for example making operator== take a StringView
to simplify the overload set.

I also removed the:
    StringView(const void* bytes, unsigned length, bool is8Bit)
constructor since it could be called by mistake when doing:
StringView("foo", 1, 2) trying to do (offset, length) when you're
supposed to do StringView("foo" + 1, 2) instead.

This had confused me on a couple occasions where I was passing a
length and setting is8Bit instead. This constructor is only needed
by CSSParserToken so lets just inline it there.

BUG=615174
Committed: https://crrev.com/ad01087faacdf31909e80c93bcf11783f99a06a4
Cr-Commit-Position: refs/heads/master@{#404943}

[esprehn, 2016-07-12 22:43:29]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 22:46:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-07-12 22:46:36]

Description was changed from

==========
Move StringView constructors into WTFString.h/AtomicString.h

This will allow String and AtomicString to depend on StringView for
methods and arguments, for example making operator== take a StringView
to simplify the overload set.

BUG=615174
==========

to

==========
Move StringView constructors into WTFString.h/AtomicString.h

This will allow String and AtomicString to depend on StringView for
methods and arguments, for example making operator== take a StringView
to simplify the overload set.

I also removed the:
    StringView(const void* bytes, unsigned length, bool is8Bit)
constructor since it could be called by mistake when doing:
   StringView("foo", 1, 2) trying to do (offset, length) when you're
supposed to do:
   StringView("foo" + 1, 2) instead.
This had confused by on a couple occasions where I was passing a
length and setting is8Bit instead. This constructor is only needed
by CSSParserToken so lets just inline it there.

BUG=615174
==========

[esprehn, 2016-07-12 22:47:14]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org, yutak@chromium.org

[esprehn, 2016-07-13 00:05:14]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[esprehn, 2016-07-13 00:05:30]

Description was changed from

==========
Move StringView constructors into WTFString.h/AtomicString.h

This will allow String and AtomicString to depend on StringView for
methods and arguments, for example making operator== take a StringView
to simplify the overload set.

I also removed the:
    StringView(const void* bytes, unsigned length, bool is8Bit)
constructor since it could be called by mistake when doing:
   StringView("foo", 1, 2) trying to do (offset, length) when you're
supposed to do:
   StringView("foo" + 1, 2) instead.
This had confused by on a couple occasions where I was passing a
length and setting is8Bit instead. This constructor is only needed
by CSSParserToken so lets just inline it there.

BUG=615174
==========

to

==========
Move StringView constructors into WTFString.h/AtomicString.h

This will allow String and AtomicString to depend on StringView for
methods and arguments, for example making operator== take a StringView
to simplify the overload set.

I also removed the:
    StringView(const void* bytes, unsigned length, bool is8Bit)
constructor since it could be called by mistake when doing:
    StringView("foo", 1, 2) trying to do (offset, length) when you're
supposed to do:
    StringView("foo" + 1, 2) instead.
This had confused by on a couple occasions where I was passing a
length and setting is8Bit instead. This constructor is only needed
by CSSParserToken so lets just inline it there.

BUG=615174
==========

[esprehn, 2016-07-13 00:05:50]

Description was changed from

==========
Move StringView constructors into WTFString.h/AtomicString.h

This will allow String and AtomicString to depend on StringView for
methods and arguments, for example making operator== take a StringView
to simplify the overload set.

I also removed the:
    StringView(const void* bytes, unsigned length, bool is8Bit)
constructor since it could be called by mistake when doing:
    StringView("foo", 1, 2) trying to do (offset, length) when you're
supposed to do:
    StringView("foo" + 1, 2) instead.
This had confused by on a couple occasions where I was passing a
length and setting is8Bit instead. This constructor is only needed
by CSSParserToken so lets just inline it there.

BUG=615174
==========

to

==========
Move StringView constructors into WTFString.h/AtomicString.h

This will allow String and AtomicString to depend on StringView for
methods and arguments, for example making operator== take a StringView
to simplify the overload set.

I also removed the:
    StringView(const void* bytes, unsigned length, bool is8Bit)
constructor since it could be called by mistake when doing:
StringView("foo", 1, 2) trying to do (offset, length) when you're
supposed to do StringView("foo" + 1, 2) instead.

This had confused by on a couple occasions where I was passing a
length and setting is8Bit instead. This constructor is only needed
by CSSParserToken so lets just inline it there.

BUG=615174
==========

[esprehn, 2016-07-13 00:06:14]

Description was changed from

==========
Move StringView constructors into WTFString.h/AtomicString.h

This will allow String and AtomicString to depend on StringView for
methods and arguments, for example making operator== take a StringView
to simplify the overload set.

I also removed the:
    StringView(const void* bytes, unsigned length, bool is8Bit)
constructor since it could be called by mistake when doing:
StringView("foo", 1, 2) trying to do (offset, length) when you're
supposed to do StringView("foo" + 1, 2) instead.

This had confused by on a couple occasions where I was passing a
length and setting is8Bit instead. This constructor is only needed
by CSSParserToken so lets just inline it there.

BUG=615174
==========

to

==========
Move StringView constructors into WTFString.h/AtomicString.h

This will allow String and AtomicString to depend on StringView for
methods and arguments, for example making operator== take a StringView
to simplify the overload set.

I also removed the:
    StringView(const void* bytes, unsigned length, bool is8Bit)
constructor since it could be called by mistake when doing:
StringView("foo", 1, 2) trying to do (offset, length) when you're
supposed to do StringView("foo" + 1, 2) instead.

This had confused me on a couple occasions where I was passing a
length and setting is8Bit instead. This constructor is only needed
by CSSParserToken so lets just inline it there.

BUG=615174
==========

[haraken, 2016-07-13 00:07:23]

LGTM

[commit-bot: I haz the power, 2016-07-13 00:07:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-07-13 00:07:56]

The CQ bit was unchecked by esprehn@chromium.org

[esprehn, 2016-07-13 00:07:58]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-07-13 00:10:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:16:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-13 02:16:38]

Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[esprehn, 2016-07-13 02:20:32]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-07-13 02:22:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 03:08:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 03:08:32]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 03:11:00]

Description was changed from

==========
Move StringView constructors into WTFString.h/AtomicString.h

This will allow String and AtomicString to depend on StringView for
methods and arguments, for example making operator== take a StringView
to simplify the overload set.

I also removed the:
    StringView(const void* bytes, unsigned length, bool is8Bit)
constructor since it could be called by mistake when doing:
StringView("foo", 1, 2) trying to do (offset, length) when you're
supposed to do StringView("foo" + 1, 2) instead.

This had confused me on a couple occasions where I was passing a
length and setting is8Bit instead. This constructor is only needed
by CSSParserToken so lets just inline it there.

BUG=615174
==========

to

==========
Move StringView constructors into WTFString.h/AtomicString.h

This will allow String and AtomicString to depend on StringView for
methods and arguments, for example making operator== take a StringView
to simplify the overload set.

I also removed the:
    StringView(const void* bytes, unsigned length, bool is8Bit)
constructor since it could be called by mistake when doing:
StringView("foo", 1, 2) trying to do (offset, length) when you're
supposed to do StringView("foo" + 1, 2) instead.

This had confused me on a couple occasions where I was passing a
length and setting is8Bit instead. This constructor is only needed
by CSSParserToken so lets just inline it there.

BUG=615174

Committed: https://crrev.com/ad01087faacdf31909e80c93bcf11783f99a06a4
Cr-Commit-Position: refs/heads/master@{#404943}
==========

[commit-bot: I haz the power, 2016-07-13 03:11:01]

Patchset 2 (id:??) landed as
https://crrev.com/ad01087faacdf31909e80c93bcf11783f99a06a4
Cr-Commit-Position: refs/heads/master@{#404943}