Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: third_party/WebKit/Source/wtf/text/StringViewTest.cpp

Issue 2140353002: Move StringView constructors into WTFString.h/AtomicString.h (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused constructor. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/text/StringView.cpp ('k') | third_party/WebKit/Source/wtf/text/WTFString.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/text/StringViewTest.cpp
diff --git a/third_party/WebKit/Source/wtf/text/StringViewTest.cpp b/third_party/WebKit/Source/wtf/text/StringViewTest.cpp
index 1b0b72e76d291660fc67456f7337a093ab73029f..6c8c620802fff555f98fc23c250917e54f3d497c 100644
--- a/third_party/WebKit/Source/wtf/text/StringViewTest.cpp
+++ b/third_party/WebKit/Source/wtf/text/StringViewTest.cpp
@@ -289,20 +289,6 @@ TEST(StringViewTest, ConstructionLiteral16)
EXPECT_EQ(String("12"), StringView(kChars16, 2).toString());
}
-TEST(StringViewTest, ConstructionRawBytes)
-{
- // StringView(const void* bytes, unsigned length, bool is8Bit);
- StringView view8(reinterpret_cast<const void*>(kChars), 2, true);
- ASSERT_TRUE(view8.is8Bit());
- EXPECT_EQ(2u, view8.length());
- EXPECT_EQ("12", view8);
-
- StringView view16(reinterpret_cast<const void*>(kChars16), 3, false);
- ASSERT_FALSE(view16.is8Bit());
- EXPECT_EQ(3u, view16.length());
- EXPECT_EQ("123", view16);
-}
-
TEST(StringViewTest, IsEmpty)
{
EXPECT_FALSE(StringView(kChars).isEmpty());
« no previous file with comments | « third_party/WebKit/Source/wtf/text/StringView.cpp ('k') | third_party/WebKit/Source/wtf/text/WTFString.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698