Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2140313004: cc: Fix non root copy request visible rect in HighDPI (Closed)

Created:
4 years, 5 months ago by weiliangc
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

cc: Fix non root copy request visible rect in HighDPI Before while transform clip into layer space, incorrectly used wrong helper function and applied device scale twice. Create correct helper function and add unittest. BUG=622083 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/2117183002 Cr-Commit-Position: refs/heads/master@{#403782} (cherry picked from commit 296dd9f02b09445ad5976396a86c00ff3181c253) Committed: https://chromium.googlesource.com/chromium/src/+/6196d6ec443cd6290a1eff911532d62b52f56d38

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -7 lines) Patch
M cc/test/layer_tree_host_common_test.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 4 chunks +26 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 3 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
weiliangc
4 years, 5 months ago (2016-07-13 20:05:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6196d6ec443cd6290a1eff911532d62b52f56d38.

Powered by Google App Engine
This is Rietveld 408576698