Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2117183002: cc: Fix non root copy request visible rect in HighDPI (Closed)

Created:
4 years, 5 months ago by weiliangc
Modified:
4 years, 5 months ago
Reviewers:
ajuma
CC:
cc-bugs_chromium.org, chromium-reviews, enne (OOO)
Base URL:
https://chromium.googlesource.com/chromium/src.git@cprequestcli
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Fix non root copy request visible rect in HighDPI Before while transform clip into layer space, incorrectly used wrong helper function and applied device scale twice. Create correct helper function and add unittest. BUG=622083 R=ajuma CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/296dd9f02b09445ad5976396a86c00ff3181c253 Cr-Commit-Position: refs/heads/master@{#403782}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -7 lines) Patch
M cc/test/layer_tree_host_common_test.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/trees/draw_property_utils.cc View 4 chunks +26 lines, -5 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 3 chunks +14 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (3 generated)
weiliangc
4 years, 5 months ago (2016-07-04 21:54:32 UTC) #2
ajuma
lgtm
4 years, 5 months ago (2016-07-04 23:11:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2117183002/1
4 years, 5 months ago (2016-07-05 14:27:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-05 15:00:08 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-05 15:00:12 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-05 15:01:27 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/296dd9f02b09445ad5976396a86c00ff3181c253
Cr-Commit-Position: refs/heads/master@{#403782}

Powered by Google App Engine
This is Rietveld 408576698