Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 2140223002: Add missing trail argument when comparing cyclic type graphs (bug uncovered by hot reload). (Closed)

Created:
4 years, 5 months ago by regis
Modified:
4 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing trail argument when comparing cyclic type graphs (bug uncovered by hot reload). R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/10b7f407c77faf2fd34a9c9cdefca0c61f447c48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M runtime/vm/object.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
4 years, 5 months ago (2016-07-12 17:46:10 UTC) #2
Cutch
lgtm
4 years, 5 months ago (2016-07-12 17:47:52 UTC) #3
regis
4 years, 5 months ago (2016-07-12 17:58:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
10b7f407c77faf2fd34a9c9cdefca0c61f447c48 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698