runtime/vm/object.cc - Issue 2140223002: Add missing trail argument when comparing cyclic type graphs (bug uncovered by hot reload).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object.cc

Issue 2140223002: Add missing trail argument when comparing cyclic type graphs (bug uncovered by hot reload). (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object.cc

diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc

index 0136eb8edd1b6ca0ddafa0edb35418db5dab9f53..f6a010f9aea279e1e5fc9a9645db258e434d1862 100644

--- a/runtime/vm/object.cc

+++ b/runtime/vm/object.cc

@@ -16729,7 +16729,8 @@ bool Type::IsEquivalent(const Instance& other, TrailPtr trail) const {

}

} else if (!type_args.IsSubvectorEquivalent(other_type_args,

from_index,

- num_type_params)) {

+ num_type_params,

+ trail)) {

return false;

}

#ifdef DEBUG

« no previous file with comments | « no previous file | no next file » | no next file with comments »