ui/file_manager/file_manager/foreground/elements/files_quick_view.js - Issue 2140113003: QuickView: Improve security by rendering images inside webview.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/file_manager/file_manager/foreground/elements/files_quick_view.js

Issue 2140113003: QuickView: Improve security by rendering images inside webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/file_manager/file_manager/foreground/elements/files_quick_view.html ('k') | ui/file_manager/file_manager/foreground/elements/files_safe_img.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/file_manager/file_manager/foreground/elements/files_quick_view.js

diff --git a/ui/file_manager/file_manager/foreground/elements/files_quick_view.js b/ui/file_manager/file_manager/foreground/elements/files_quick_view.js

index a76c4fefcdaba5fb949788a94fc634ff6f58f494..9094af0acba58be4177f3064904b9a02afc00304 100644

--- a/ui/file_manager/file_manager/foreground/elements/files_quick_view.js

+++ b/ui/file_manager/file_manager/foreground/elements/files_quick_view.js

@@ -9,6 +9,8 @@ var FilesQuickView = Polymer({

// File media type, e.g. image, video.

type: String,

filePath: String,

+ // URLs should be accessible from webview since contets are rendered inside

+ // it. Hint: use URL.createObjectURL.

contentUrl: String,

videoPoster: String,

audioArtwork: String,

@@ -24,6 +26,7 @@ var FilesQuickView = Polymer({

listeners: {

'iron-overlay-closed': 'clear',

+ 'files-safe-img-tap-outside': 'close',

// Clears fields.