Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: ui/file_manager/file_manager/foreground/elements/files_quick_view.html

Issue 2140113003: QuickView: Improve security by rendering images inside webview. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/file_manager/file_manager/foreground/elements/files_quick_view.html
diff --git a/ui/file_manager/file_manager/foreground/elements/files_quick_view.html b/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
index e3de1d7f03f0810a1e683f5bf54addeca2d75b24..d36cef78e1b26ef61ca30de54c8703335f050e3f 100644
--- a/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
+++ b/ui/file_manager/file_manager/foreground/elements/files_quick_view.html
@@ -9,6 +9,7 @@
<link rel="import" href="chrome://resources/polymer/v1_0/paper-dialog/paper-dialog.html">
<link rel="import" href="chrome://resources/polymer/v1_0/paper-toolbar/paper-toolbar.html">
<link rel="import" href="files_metadata_box.html">
+<link rel="import" href="files_safe_img.html">
<link rel="import" href="files_tooltip.html">
<link rel="import" href="icons.html">
@@ -32,7 +33,7 @@
<div class='close-on-click' id="innerContentPanel" tabindex="0">
<template is="dom-if" if="[[isImage_(type)]]">
<div class="close-on-click" hidden="[[!contentUrl]]">
- <img class="content" src="[[contentUrl]]">
+ <files-safe-img class="content" src="[[contentUrl]]"></files-safe-img>
</div>
<template is="dom-if" if="[[!contentUrl]]">
<div generic-thumbnail="image"></div>
@@ -45,7 +46,7 @@
</template>
<template is="dom-if" if="[[!contentUrl]]">
<div class="thumbnail" hidden="[[!videoPoster]]">
- <img id="video-poster" src="[[videoPoster]]">
+ <files-safe-img id="video-poster" src="[[videoPoster]]"></files-safe-img>
</div>
<div hidden="[[videoPoster]]" generic-thumbnail="video"></div>
<div class="no-preview" i18n-content="QUICK_VIEW_NO_PLAYBACK_AVAILABLE"></div>
@@ -53,7 +54,7 @@
</template>
<template is="dom-if" if="[[isAudio_(type)]]">
<template is="dom-if" if="[[audioArtwork]]">
- <img id="audio-artwork" src="[[audioArtwork]]"></img>
+ <files-safe-img id="audio-artwork" src="[[audioArtwork]]"></files-safe-img>
</template>
<template is="dom-if" if="[[contentUrl]]">
<div>

Powered by Google App Engine
This is Rietveld 408576698