Out-of-line ResourceRequest/ResourceResponse ctors to save a few KB.

Out-of-line ResourceRequest/ResourceResponse ctors to save a few KB.

BUG=none

Committed: https://crrev.com/5ec6b59e8d82e1f47eee4108898ad63fb783686f
Cr-Commit-Position: refs/heads/master@{#404895}

[dcheng, 2016-07-12 05:31:57]

Description was changed from

==========
Out-of-line ResourceRequest/ResourceResponse ctors to save a few KB.

BUG=none
==========

to

==========
Out-of-line ResourceRequest/ResourceResponse ctors to save a few KB.

BUG=none
==========

[dcheng, 2016-07-12 05:31:57]

dcheng@chromium.org changed reviewers:
+ kinuko@chromium.org

[dcheng, 2016-07-12 05:33:11]

Noticed this during the recent WebURLRequest / WebURLResponse cleanups. It's not
a huge savings: it's 12-13KB on a release Linux build. Think it's worth it?

My main concern would be a perf hit, but DocumentLoader is already such a heavy
class.

https://codereview.chromium.org/2140033002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/network/ResourceRequest.h (right):

https://codereview.chromium.org/2140033002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/network/ResourceRequest.h:77:
ResourceRequest(const String& urlString);
I tried to make these explicit, but it turns out a lot of places rely on this.

[kinuko, 2016-07-12 06:16:44]

Let's try landing this and revert if we see sign of regressions :)

lgtm

[dcheng, 2016-07-12 06:18:26]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-07-12 06:19:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 07:37:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 07:37:58]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[dcheng, 2016-07-12 07:45:18]

PTAL, I fixed a dumb mistake.

https://codereview.chromium.org/2140033002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/network/ResourceRequest.cpp (right):

https://codereview.chromium.org/2140033002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/network/ResourceRequest.cpp:45:
initialize(KURL());
I forgot to include this line when moving the code =(

[kinuko, 2016-07-12 07:59:01]

On 2016/07/12 07:45:18, dcheng wrote:
> PTAL, I fixed a dumb mistake.
> 
>
https://codereview.chromium.org/2140033002/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/platform/network/ResourceRequest.cpp (right):
> 
>
https://codereview.chromium.org/2140033002/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/platform/network/ResourceRequest.cpp:45:
> initialize(KURL());
> I forgot to include this line when moving the code =(

Looks like I wasn't really looking into the code either... still lgtm

[dcheng, 2016-07-12 13:01:12]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-07-12 13:01:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 16:35:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 16:35:53]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2016-07-13 00:30:21]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-07-13 00:34:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 02:13:27]

Description was changed from

==========
Out-of-line ResourceRequest/ResourceResponse ctors to save a few KB.

BUG=none
==========

to

==========
Out-of-line ResourceRequest/ResourceResponse ctors to save a few KB.

BUG=none
==========

[commit-bot: I haz the power, 2016-07-13 02:13:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 02:14:08]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 02:15:05]

Description was changed from

==========
Out-of-line ResourceRequest/ResourceResponse ctors to save a few KB.

BUG=none
==========

to

==========
Out-of-line ResourceRequest/ResourceResponse ctors to save a few KB.

BUG=none

Committed: https://crrev.com/5ec6b59e8d82e1f47eee4108898ad63fb783686f
Cr-Commit-Position: refs/heads/master@{#404895}
==========

[commit-bot: I haz the power, 2016-07-13 02:15:06]

Patchset 2 (id:??) landed as
https://crrev.com/5ec6b59e8d82e1f47eee4108898ad63fb783686f
Cr-Commit-Position: refs/heads/master@{#404895}