Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: third_party/WebKit/Source/platform/network/ResourceRequest.cpp

Issue 2140033002: Out-of-line ResourceRequest/ResourceResponse ctors to save a few KB. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't forget to call initialize() in moved code =( Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/network/ResourceRequest.cpp
diff --git a/third_party/WebKit/Source/platform/network/ResourceRequest.cpp b/third_party/WebKit/Source/platform/network/ResourceRequest.cpp
index c05ad61869bafa944c2bbae7b8b150d9e23529b1..99b0af315da7956d87f4fd9505f138ffa1b82c5e 100644
--- a/third_party/WebKit/Source/platform/network/ResourceRequest.cpp
+++ b/third_party/WebKit/Source/platform/network/ResourceRequest.cpp
@@ -40,6 +40,21 @@ namespace blink {
double ResourceRequest::s_defaultTimeoutInterval = INT_MAX;
+ResourceRequest::ResourceRequest()
+{
+ initialize(KURL());
dcheng 2016/07/12 07:45:18 I forgot to include this line when moving the code
+}
+
+ResourceRequest::ResourceRequest(const String& urlString)
+{
+ initialize(KURL(ParsedURLString, urlString));
+}
+
+ResourceRequest::ResourceRequest(const KURL& url)
+{
+ initialize(url);
+}
+
ResourceRequest::ResourceRequest(CrossThreadResourceRequestData* data)
: ResourceRequest()
{
@@ -80,6 +95,10 @@ ResourceRequest::ResourceRequest(CrossThreadResourceRequestData* data)
m_redirectStatus = data->m_redirectStatus;
}
+ResourceRequest::ResourceRequest(const ResourceRequest&) = default;
+
+ResourceRequest& ResourceRequest::operator=(const ResourceRequest&) = default;
+
std::unique_ptr<CrossThreadResourceRequestData> ResourceRequest::copyData() const
{
std::unique_ptr<CrossThreadResourceRequestData> data = wrapUnique(new CrossThreadResourceRequestData());

Powered by Google App Engine
This is Rietveld 408576698