Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Issue 2139973002: Adjust the comment for W3C test harness tutorial in PRESUBMIT.py (Closed)

Created:
4 years, 5 months ago by eroman
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, Mike West
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust the comment for W3C test harness tutorial in PRESUBMIT.py Committed: https://crrev.com/db6c0a5c9890de7a94d7e9b5c9a0cb368077b37f Cr-Commit-Position: refs/heads/master@{#404865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/PRESUBMIT.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
eroman
4 years, 5 months ago (2016-07-12 01:52:05 UTC) #2
Mike West
LGTM. :)
4 years, 5 months ago (2016-07-12 09:35:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139973002/1
4 years, 5 months ago (2016-07-12 19:10:25 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/216461)
4 years, 5 months ago (2016-07-12 21:15:02 UTC) #7
eroman
@dpranke for OWNERs approval
4 years, 5 months ago (2016-07-12 21:23:24 UTC) #9
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-12 22:23:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139973002/1
4 years, 5 months ago (2016-07-12 22:56:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 00:23:43 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 00:23:53 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 00:25:39 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/db6c0a5c9890de7a94d7e9b5c9a0cb368077b37f
Cr-Commit-Position: refs/heads/master@{#404865}

Powered by Google App Engine
This is Rietveld 408576698