| OLD | NEW |
| 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. |
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
| 4 | 4 |
| 5 """Top-level presubmit script for Blink. | 5 """Top-level presubmit script for Blink. |
| 6 | 6 |
| 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
| 8 for more details about the presubmit API built into gcl. | 8 for more details about the presubmit API built into gcl. |
| 9 """ | 9 """ |
| 10 | 10 |
| (...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 199 errors = input_api.canned_checks._FindNewViolationsOfRule( | 199 errors = input_api.canned_checks._FindNewViolationsOfRule( |
| 200 lambda _, x: not jstest_re.search(x), input_api, source_file_filter) | 200 lambda _, x: not jstest_re.search(x), input_api, source_file_filter) |
| 201 errors = [' * %s' % violation for violation in errors] | 201 errors = [' * %s' % violation for violation in errors] |
| 202 if errors: | 202 if errors: |
| 203 return [output_api.PresubmitPromptOrNotify( | 203 return [output_api.PresubmitPromptOrNotify( |
| 204 '"resources/js-test.js" is deprecated; please write new layout ' | 204 '"resources/js-test.js" is deprecated; please write new layout ' |
| 205 'tests using the assertions in "resources/testharness.js" ' | 205 'tests using the assertions in "resources/testharness.js" ' |
| 206 'instead, as these can be more easily upstreamed to Web Platform ' | 206 'instead, as these can be more easily upstreamed to Web Platform ' |
| 207 'Tests for cross-vendor compatibility testing. If you\'re not ' | 207 'Tests for cross-vendor compatibility testing. If you\'re not ' |
| 208 'already familiar with this framework, a tutorial is available at ' | 208 'already familiar with this framework, a tutorial is available at ' |
| 209 'https://darobin.github.io/test-harness-tutorial/docs/using-testharn
ess.html.' | 209 'https://darobin.github.io/test-harness-tutorial/docs/using-testharn
ess.html' |
| 210 'with the new framework.\n\n%s' % '\n'.join(errors))] | 210 '\n\n%s' % '\n'.join(errors))] |
| 211 return [] | 211 return [] |
| 212 | 212 |
| 213 def _CheckForFailInFile(input_api, f): | 213 def _CheckForFailInFile(input_api, f): |
| 214 pattern = input_api.re.compile('^FAIL') | 214 pattern = input_api.re.compile('^FAIL') |
| 215 errors = [] | 215 errors = [] |
| 216 for line_num, line in f.ChangedContents(): | 216 for line_num, line in f.ChangedContents(): |
| 217 if pattern.match(line): | 217 if pattern.match(line): |
| 218 errors.append(' %s:%d %s' % (f.LocalPath(), line_num, line)) | 218 errors.append(' %s:%d %s' % (f.LocalPath(), line_num, line)) |
| 219 return errors | 219 return errors |
| 220 | 220 |
| (...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
| 340 for master in masters: | 340 for master in masters: |
| 341 try_config.setdefault(master, {}) | 341 try_config.setdefault(master, {}) |
| 342 for builder in masters[master]: | 342 for builder in masters[master]: |
| 343 # Do not trigger presubmit builders, since they're likely to fail | 343 # Do not trigger presubmit builders, since they're likely to fail |
| 344 # (e.g. OWNERS checks before finished code review), and we're | 344 # (e.g. OWNERS checks before finished code review), and we're |
| 345 # running local presubmit anyway. | 345 # running local presubmit anyway. |
| 346 if 'presubmit' not in builder: | 346 if 'presubmit' not in builder: |
| 347 try_config[master][builder] = ['defaulttests'] | 347 try_config[master][builder] = ['defaulttests'] |
| 348 | 348 |
| 349 return try_config | 349 return try_config |
| OLD | NEW |