Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2139833002:
Flip main remaining Win builders to GN. (Closed)
|
Created:
4 years, 5 months ago by Dirk Pranke Modified:
4 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@clean_up_deleted_builders Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFlip main remaining Win builders to GN.
Specifically:
- chromium
- Win
- chromium.perf
- Win Builder
- official.desktop
- win
- win64
- official.desktop.continuous
- win trunk
There are still various FYI and memory builders on GYP, as well as
the GYP builders on the chromium.win waterfall.
R=brucedawson@chromium.org, brettw@chromium.org
BUG=623659
Committed: https://crrev.com/8524d4afab4f543f93d53f6e97c3c4e03502bfbd
Cr-Commit-Position: refs/heads/master@{#405178}
Patch Set 1 #Patch Set 2 : merge #Patch Set 3 : merge #
Dependent Patchsets: Messages
Total messages: 27 (15 generated)
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
lgtm
On 2016/07/11 21:54:17, brettw (ping after 24h) wrote: > lgtm hmm, I'm not sure why the patch failed, but I'll wait for the other ancestor CLs to land and try again just to be safe.
The CQ bit was checked by dpranke@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I'll plan to try and land this tomorrow morning when I can keep an eye on things.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dpranke@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org Link to the patchset: https://codereview.chromium.org/2139833002/#ps40001 (title: "merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dpranke@chromium.org
The CQ bit was checked by dpranke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Flip main remaining Win builders to GN. Specifically: - chromium - Win - chromium.perf - Win Builder - official.desktop - win - win64 - official.desktop.continuous - win trunk There are still various FYI and memory builders on GYP, as well as the GYP builders on the chromium.win waterfall. R=brucedawson@chromium.org, brettw@chromium.org BUG=623659 ========== to ========== Flip main remaining Win builders to GN. Specifically: - chromium - Win - chromium.perf - Win Builder - official.desktop - win - win64 - official.desktop.continuous - win trunk There are still various FYI and memory builders on GYP, as well as the GYP builders on the chromium.win waterfall. R=brucedawson@chromium.org, brettw@chromium.org BUG=623659 Committed: https://crrev.com/8524d4afab4f543f93d53f6e97c3c4e03502bfbd Cr-Commit-Position: refs/heads/master@{#405178} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/8524d4afab4f543f93d53f6e97c3c4e03502bfbd Cr-Commit-Position: refs/heads/master@{#405178}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2144173002/ by dpranke@chromium.org. The reason for reverting is: Build failures on the win and win64 official builders :( See crbug.com/628056 and crbug.com/628055. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
