Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 2139673002: GLContextGLX: try all GL versions from the highest. (Closed)

Created:
4 years, 5 months ago by Corentin Wallez
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GLContextGLX: try all GL versions from the highest. Also try all ES versions from the highest. This change will allow Chrome to create a GL context higher than 3.0 on Mesa and will in turn allow WebGL2 to run on Intel Linux when using the native GL driver. This patch is a direct port of the logic in ANGLE's DisplayGLX This is a reland of 3d090e4477520e14b782d2398e4a143982e189d4 after fixes for core profile support on Intel Mesa. This was a reland of 3464004765597c914d8499ee9792cf81e106a4ae trying a compatibility context first instead of a core context. (for non-Mesa drivers) BUG=598902 Review-Url: https://codereview.chromium.org/1999543003 Review-Url: https://codereview.chromium.org/2098613004 Committed: https://crrev.com/35ec773b64c07f58b0e59377d917f6424edda189 Cr-Original-Original-Commit-Position: refs/heads/master@{#396243} Cr-Original-Commit-Position: refs/heads/master@{#402291} Cr-Commit-Position: refs/heads/master@{#404698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -13 lines) Patch
M ui/gl/gl_context_glx.cc View 2 chunks +131 lines, -13 lines 0 comments Download
M ui/gl/gl_surface_glx.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_glx.cc View 3 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Corentin Wallez
PTAL, this is another reland of this patch. There are no modifications compared to the ...
4 years, 5 months ago (2016-07-11 17:17:04 UTC) #2
Ken Russell (switch to Gerrit)
LGTM. Let's try it again.
4 years, 5 months ago (2016-07-11 17:42:00 UTC) #3
piman
lgtm
4 years, 5 months ago (2016-07-11 17:58:05 UTC) #4
Corentin Wallez
Thanks, CQing.
4 years, 5 months ago (2016-07-11 18:00:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139673002/1
4 years, 5 months ago (2016-07-11 18:00:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-11 18:48:52 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-11 18:50:45 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/35ec773b64c07f58b0e59377d917f6424edda189
Cr-Commit-Position: refs/heads/master@{#404698}

Powered by Google App Engine
This is Rietveld 408576698