GLContextGLX: try all GL versions from the highest.

GLContextGLX: try all GL versions from the highest.

Also try all ES versions from the highest. This change will allow
Chrome to create a GL context higher than 3.0 on Mesa and will in turn
allow WebGL2 to run on Intel Linux when using the native GL driver.

This patch is a direct port of the logic in ANGLE's DisplayGLX

This is a reland of 3464004765597c914d8499ee9792cf81e106a4ae trying a
compatibility context first instead of a core context. (for non-Mesa
drivers)

BUG=598902
Review-Url: https://codereview.chromium.org/1999543003
Committed: https://crrev.com/3d090e4477520e14b782d2398e4a143982e189d4
Cr-Original-Commit-Position: refs/heads/master@{#396243}
Cr-Commit-Position: refs/heads/master@{#402291}

[Corentin Wallez, 2016-06-24 20:08:20]

cwallez@chromium.org changed reviewers:
+ kbr@chromium.org, piman@chromium.org, zmo@chromium.org

[Corentin Wallez, 2016-06-24 20:08:20]

PTAL, this is a reland of the GLContextGLX change that makes Chrome able to
create a 3.3 context on Mesa.

[piman, 2016-06-24 21:31:45]

lgtm

https://codereview.chromium.org/2098613004/diff/1/ui/gl/gl_context_glx.cc
File ui/gl/gl_context_glx.cc (right):

https://codereview.chromium.org/2098613004/diff/1/ui/gl/gl_context_glx.cc#new...
ui/gl/gl_context_glx.cc:34: int profileMask) {
nit: profile_mask

https://codereview.chromium.org/2098613004/diff/1/ui/gl/gl_context_glx.cc#new...
ui/gl/gl_context_glx.cc:60: auto oldErrorHandler =
XSetErrorHandler(IgnoreX11Errors);
nit: old_error_handler

https://codereview.chromium.org/2098613004/diff/1/ui/gl/gl_context_glx.cc#new...
ui/gl/gl_context_glx.cc:83: int profileFlag;
nit: profile_flag

[Ken Russell (switch to Gerrit), 2016-06-24 22:58:16]

lgtm too with piman's comments addressed.

[Corentin Wallez, 2016-06-27 15:39:22]

Thanks for the review. Will land this after the two previous patches are landed.

https://codereview.chromium.org/2098613004/diff/1/ui/gl/gl_context_glx.cc
File ui/gl/gl_context_glx.cc (right):

https://codereview.chromium.org/2098613004/diff/1/ui/gl/gl_context_glx.cc#new...
ui/gl/gl_context_glx.cc:34: int profileMask) {
On 2016/06/24 at 21:31:45, piman wrote:
> nit: profile_mask

Done

https://codereview.chromium.org/2098613004/diff/1/ui/gl/gl_context_glx.cc#new...
ui/gl/gl_context_glx.cc:60: auto oldErrorHandler =
XSetErrorHandler(IgnoreX11Errors);
On 2016/06/24 at 21:31:45, piman wrote:
> nit: old_error_handler

Done

https://codereview.chromium.org/2098613004/diff/1/ui/gl/gl_context_glx.cc#new...
ui/gl/gl_context_glx.cc:83: int profileFlag;
On 2016/06/24 at 21:31:45, piman wrote:
> nit: profile_flag

Done

[Corentin Wallez, 2016-06-27 20:06:24]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2016-06-27 20:06:25]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2098613004/#ps20001
(title: "Address nits")

[commit-bot: I haz the power, 2016-06-27 20:07:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 21:35:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-27 21:38:35]

Description was changed from

==========
GLContextGLX: try all GL versions from the highest.

Also try all ES versions from the highest. This change will allow
Chrome to create a GL context higher than 3.0 on Mesa and will in turn
allow WebGL2 to run on Intel Linux when using the native GL driver.

This patch is a direct port of the logic in ANGLE's DisplayGLX

This is a reland of 3464004765597c914d8499ee9792cf81e106a4ae trying a
compatibility context first instead of a core context. (for non-Mesa
drivers)

BUG=598902

Review-Url: https://codereview.chromium.org/1999543003
Cr-Commit-Position: refs/heads/master@{#396243}
==========

to

==========
GLContextGLX: try all GL versions from the highest.

Also try all ES versions from the highest. This change will allow
Chrome to create a GL context higher than 3.0 on Mesa and will in turn
allow WebGL2 to run on Intel Linux when using the native GL driver.

This patch is a direct port of the logic in ANGLE's DisplayGLX

This is a reland of 3464004765597c914d8499ee9792cf81e106a4ae trying a
compatibility context first instead of a core context. (for non-Mesa
drivers)

BUG=598902

Review-Url: https://codereview.chromium.org/1999543003
Committed: https://crrev.com/3d090e4477520e14b782d2398e4a143982e189d4
Cr-Original-Commit-Position: refs/heads/master@{#396243}
Cr-Commit-Position: refs/heads/master@{#402291}
==========

[commit-bot: I haz the power, 2016-06-27 21:38:36]

Patchset 2 (id:??) landed as
https://crrev.com/3d090e4477520e14b782d2398e4a143982e189d4
Cr-Commit-Position: refs/heads/master@{#402291}

[Corentin Wallez, 2016-06-28 14:23:28]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2104983002/ by cwallez@chromium.org.

The reason for reverting is: Causes failures on the GPU FYI Linux Intel bot..