Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 2139663002: [Turbofan] Add support for 16 byte frame slots. (Closed)

Created:
4 years, 5 months ago by bbudge
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Turbofan] Add support for 16 byte frame slots. AllocateSpillSlot can now handle requests for 16 byte slots. LOG=N BUG=v8:4124 Committed: https://crrev.com/3848099911e352346d2628f92f347acfd5ba23c7 Cr-Commit-Position: refs/heads/master@{#37661}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Fix the patch. #

Patch Set 4 : Remove TODO. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M src/compiler/frame.h View 1 2 1 chunk +14 lines, -6 lines 0 comments Download
M src/compiler/register-allocator.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bbudge
4 years, 5 months ago (2016-07-11 18:09:09 UTC) #2
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-12 03:01:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139663002/60001
4 years, 5 months ago (2016-07-12 03:02:17 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-12 03:26:20 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 03:28:04 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3848099911e352346d2628f92f347acfd5ba23c7
Cr-Commit-Position: refs/heads/master@{#37661}

Powered by Google App Engine
This is Rietveld 408576698