third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h - Issue 2139543002: [DevTools] Report console API calls through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

Issue 2139543002: [DevTools] Report console API calls through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

index 6944c35439bfdf3a7ec7dc0e20f6583f5a7ed2fb..6844a39c49cef5f729da5353f4a70e1f45917171 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h

@@ -39,8 +39,7 @@ public:

virtual void consoleTime(const String16& title) = 0;

virtual void consoleTimeEnd(const String16& title) = 0;

virtual void consoleTimeStamp(const String16& title) = 0;

- // TODO(dgozman: route all messages through here, remove FrameConsole.

- virtual void messageAddedToConsole(int contextGroupId, MessageSource, MessageLevel, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) = 0;

+ virtual void consoleAPIMessage(int contextGroupId, MessageLevel, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, V8StackTrace*) = 0;

kozy 2016/07/13 18:48:49 Please replace this method in V8Inspector.h

dgozman 2016/07/13 21:08:07 Done.

virtual v8::MaybeLocal<v8::Value> memoryInfo(v8::Isolate*, v8::Local<v8::Context>) = 0;