third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h - Issue 2139543002: [DevTools] Report console API calls through Runtime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

Issue 2139543002: [DevTools] Report console API calls through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp ('K') | « third_party/WebKit/Source/platform/v8_inspector/js_protocol.json ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h » ('j') | third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

index 576e2dfe0053e507a1f5c6a602d7be604f9af198..483dea8f686977d364b77c12117c5ddb381e0cf9 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h

@@ -55,7 +55,7 @@ public:

// TODO(dgozman): remove requestIdentifier.

virtual void addConsoleMessage(int contextGroupId, MessageSource, MessageLevel, const String16& message, const String16& url, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, int scriptId, const String16& requestIdentifier, const String16& workerId) = 0;

// TODO(dgozman): can we remove this method?

- virtual void logToConsole(v8::Local<v8::Context>, const String16& message, v8::Local<v8::Value> arg1, v8::Local<v8::Value> arg2) = 0;

+ virtual void logToConsole(v8::Local<v8::Context>, v8::Local<v8::Value> arg1, v8::Local<v8::Value> arg2) = 0;

// TODO(dgozman): try to remove this.

virtual void consoleMessagesCount(int contextGroupId, unsigned* total, unsigned* withArguments) = 0;