Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

Issue 2139543002: [DevTools] Report console API calls through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
index cce207b2e52bdadac2c9eddf805947a2df0da74b..dbf75dd548cf895af53a3b0c4229ec4c001f4ec3 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp
@@ -95,14 +95,14 @@ void V8ConsoleAgentImpl::reportAllMessages()
m_frontend.flush();
}
for (const auto& message : storage->messages()) {
- if (message->origin() == V8MessageOrigin::kConsole)
+ if (message->origin() == V8MessageOrigin::kExternalConsole)
reportMessage(message.get(), false);
}
}
void V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generatePreview)
{
- DCHECK_EQ(V8MessageOrigin::kConsole, message->origin());
+ DCHECK_EQ(V8MessageOrigin::kExternalConsole, message->origin());
message->reportToFrontend(&m_frontend, m_session, generatePreview);
m_frontend.flush();
}

Powered by Google App Engine
This is Rietveld 408576698