Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleAgentImpl.cpp

Issue 2139543002: [DevTools] Report console API calls through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/v8_inspector/V8ConsoleAgentImpl.h" 5 #include "platform/v8_inspector/V8ConsoleAgentImpl.h"
6 6
7 #include "platform/v8_inspector/V8ConsoleMessage.h" 7 #include "platform/v8_inspector/V8ConsoleMessage.h"
8 #include "platform/v8_inspector/V8DebuggerImpl.h" 8 #include "platform/v8_inspector/V8DebuggerImpl.h"
9 #include "platform/v8_inspector/V8InspectorSessionImpl.h" 9 #include "platform/v8_inspector/V8InspectorSessionImpl.h"
10 #include "platform/v8_inspector/V8StackTraceImpl.h" 10 #include "platform/v8_inspector/V8StackTraceImpl.h"
(...skipping 77 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 .setTimestamp(0) 88 .setTimestamp(0)
89 .build(); 89 .build();
90 expired->setType(protocol::Console::ConsoleMessage::TypeEnum::Log); 90 expired->setType(protocol::Console::ConsoleMessage::TypeEnum::Log);
91 expired->setLine(0); 91 expired->setLine(0);
92 expired->setColumn(0); 92 expired->setColumn(0);
93 expired->setUrl(""); 93 expired->setUrl("");
94 m_frontend.messageAdded(std::move(expired)); 94 m_frontend.messageAdded(std::move(expired));
95 m_frontend.flush(); 95 m_frontend.flush();
96 } 96 }
97 for (const auto& message : storage->messages()) { 97 for (const auto& message : storage->messages()) {
98 if (message->origin() == V8MessageOrigin::kConsole) 98 if (message->origin() == V8MessageOrigin::kExternalConsole)
99 reportMessage(message.get(), false); 99 reportMessage(message.get(), false);
100 } 100 }
101 } 101 }
102 102
103 void V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generateP review) 103 void V8ConsoleAgentImpl::reportMessage(V8ConsoleMessage* message, bool generateP review)
104 { 104 {
105 DCHECK_EQ(V8MessageOrigin::kConsole, message->origin()); 105 DCHECK_EQ(V8MessageOrigin::kExternalConsole, message->origin());
106 message->reportToFrontend(&m_frontend, m_session, generatePreview); 106 message->reportToFrontend(&m_frontend, m_session, generatePreview);
107 m_frontend.flush(); 107 m_frontend.flush();
108 } 108 }
109 109
110 } // namespace blink 110 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698