Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h

Issue 2139543002: [DevTools] Report console API calls through Runtime. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
index d6ada6151aafabce69a833ea4419f5be685c6f37..59cef532c263ec8e079fa38f7d28259db2458c0c 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.h
@@ -21,9 +21,9 @@ class V8DebuggerImpl;
class V8InspectorSessionImpl;
class V8StackTrace;
-enum class V8MessageOrigin { kConsole, kException, kRevokedException };
+enum class V8MessageOrigin { kExternalConsole, kConsole, kException, kRevokedException };
-enum class ConsoleAPIType { kLog, kDir, kDirXML, kTable, kTrace, kStartGroup, kStartGroupCollapsed, kEndGroup, kClear, kAssert, kTimeEnd, kCount };
+enum class ConsoleAPIType { kLog, kDebug, kInfo, kError, kWarning, kDir, kDirXML, kTable, kTrace, kStartGroup, kStartGroupCollapsed, kEndGroup, kClear, kAssert, kTimeEnd, kCount };
class V8ConsoleMessage {
public:
@@ -32,9 +32,7 @@ public:
static std::unique_ptr<V8ConsoleMessage> createForConsoleAPI(
double timestamp,
ConsoleAPIType,
- MessageLevel,
- const String16& message,
- std::vector<v8::Local<v8::Value>>* arguments,
+ const std::vector<v8::Local<v8::Value>>& arguments,
std::unique_ptr<V8StackTrace>,
InspectedContext*);

Powered by Google App Engine
This is Rietveld 408576698