[InstantExtended] Fixing how PageLoadSRP is emitted. Previously it was emitted only for Instant sea…

chrome/browser/autocomplete/autocomplete_input.h

Index: chrome/browser/autocomplete/autocomplete_input.h
diff --git a/chrome/browser/autocomplete/autocomplete_input.h b/chrome/browser/autocomplete/autocomplete_input.h
index 00708724e8a88eaf0147b5cc778603f84447cb30..e5fe67c69548e4453951988c179eb0b3f69e6973 100644
--- a/chrome/browser/autocomplete/autocomplete_input.h
+++ b/chrome/browser/autocomplete/autocomplete_input.h
@@ -62,7 +62,10 @@ class AutocompleteInput {
     // The user is on a search result page that's doing search term
     // replacement, meaning the search terms should've appeared in the omnibox
     // before the user started editing it, not the URL of the page.
-    SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT = 6
+    SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT = 6,
+	  // The user in a search result page that's not doing search term

[Mark P, 2013/08/06 19:38:36]

nit: horizontal spacing

ditto in proto file

[Peter Kasting, 2013/08/06 21:32:19]

Also, grammar (in both places).  "The user in"?

[rpetterson, 2013/08/06 23:04:17]

Done. In the proto file as well.

[rpetterson, 2013/08/06 23:04:17]

Done.

+    // replacement, meaning the URL of the page shows in the omnibox.

[Mark P, 2013/08/06 19:38:36]

minor nit: consider ending the sentence with a similar structure to that above
by changing
"shows in the omnibox" to "should've appeared in the omnibox before the user
started editing it"

ditto in proto file

[rpetterson, 2013/08/06 23:04:17]

Done. In the proto file as well.

+    SEARCH_RESULT_PAGE_NOT_DOING_SEARCH_TERM_REPLACEMENT = 7

[Mark P, 2013/08/06 19:38:36]

Note: you will have to resolve against
https://codereview.chromium.org/20587003/
, which also adds enum entries, before submitting.

[rpetterson, 2013/08/06 23:04:17]

I will do a separate rebase upload after the upload to fix comment concerns.

   };

[Mark P, 2013/08/06 19:38:36]

As you added an entry here, you need to add the translation of it into the enum
in
AsOmniboxEventPageClassification()
in
chrome/browser/metrics/metrics_log.cc

In fact, I'm amazed this compiles without doing that--I was told that chromium
has its compiler set to crash on switch statements that either don't handle all
inputs (e.g. enums) and lack a default case.

[rpetterson, 2013/08/06 23:04:17]

Done.

 
   AutocompleteInput();