[InstantExtended] Fixing how PageLoadSRP is emitted. Previously it was emitted only for Instant sea…

chrome/browser/autocomplete/autocomplete_input.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_INPUT_H_
 #define CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_INPUT_H_
 
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 44 matching lines @@
     // version; it could be replaced by an extension.
     BLANK = 2,          // about:blank
     HOMEPAGE = 3,       // user switched settings to "open this page" mode.
     // Note that if the homepage is set to the new tab page or about blank,
     // then we'll classify the web page into those categories, not HOMEPAGE.
     OTHER = 4,          // everything not included somewhere else on this list
     INSTANT_NEW_TAB_PAGE = 5,  // new tab page rendered by Instant
     // The user is on a search result page that's doing search term
     // replacement, meaning the search terms should've appeared in the omnibox
     // before the user started editing it, not the URL of the page.
-    SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT = 6
+    SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT = 6,
+          // The user in a search result page that's not doing search term

[Mark P, 2013/08/06 19:38:36]

nit: horizontal spacing

ditto in proto file

[Peter Kasting, 2013/08/06 21:32:19]

Also, grammar (in both places).  "The user in"?

[rpetterson, 2013/08/06 23:04:17]

Done. In the proto file as well.

[rpetterson, 2013/08/06 23:04:17]

Done.

+    // replacement, meaning the URL of the page shows in the omnibox.

[Mark P, 2013/08/06 19:38:36]

minor nit: consider ending the sentence with a similar structure to that above
by changing
"shows in the omnibox" to "should've appeared in the omnibox before the user
started editing it"

ditto in proto file

[rpetterson, 2013/08/06 23:04:17]

Done. In the proto file as well.

+    SEARCH_RESULT_PAGE_NOT_DOING_SEARCH_TERM_REPLACEMENT = 7

[Mark P, 2013/08/06 19:38:36]

Note: you will have to resolve against
https://codereview.chromium.org/20587003/
, which also adds enum entries, before submitting.

[rpetterson, 2013/08/06 23:04:17]

I will do a separate rebase upload after the upload to fix comment concerns.

   };

[Mark P, 2013/08/06 19:38:36]

As you added an entry here, you need to add the translation of it into the enum
in
AsOmniboxEventPageClassification()
in
chrome/browser/metrics/metrics_log.cc

In fact, I'm amazed this compiles without doing that--I was told that chromium
has its compiler set to crash on switch statements that either don't handle all
inputs (e.g. enums) and lack a default case.

[rpetterson, 2013/08/06 23:04:17]

Done.

 
   AutocompleteInput();
   // |text| and |cursor_position| represent the input query and location of
   // the cursor with the query respectively.  |cursor_position| may be set to
   // string16::npos if the input |text| doesn't come directly from the user's
   // typing.
   //
   // |desired_tld| is the user's desired TLD, if one is not already present in
   // the text to autocomplete.  When this is non-empty, it also implies that
   // "www." should be prepended to the domain where possible. The |desired_tld|
@@ skipping 145 matching lines @@
   url_parse::Parsed parts_;
   string16 scheme_;
   GURL canonicalized_url_;
   bool prevent_inline_autocomplete_;
   bool prefer_keyword_;
   bool allow_exact_keyword_match_;
   MatchesRequested matches_requested_;
 };
 
 #endif  // CHROME_BROWSER_AUTOCOMPLETE_AUTOCOMPLETE_INPUT_H_