Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 2139403003: Revert of Turn flag opt-in-ime-menu on by default. (patchset #2 id:20001 of https://codereview.chro… (Closed)

Created:
4 years, 5 months ago by Azure Wei
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Revert of Turn flag opt-in-ime-menu on by default. (patchset #2 id:20001 of https://codereview.chromium.org/2068953002/ ) Reason for revert: This feature will not be launched in M53. Original issue's description: > Turn flag: opt-in-ime-menu on by default, which aims to launch on M53. > > BUG=570761 > TEST=Verified on local build. > > Committed: https://crrev.com/8a07498f562fc6bab382e01b5e711421fa30ef72 > Cr-Commit-Position: refs/heads/master@{#400374} TBR=thestig@chromium.org NOPRESUBMIT=true NOTRY=true BUG=570761, 626575 Review-Url: https://codereview.chromium.org/2123363003 Cr-Commit-Position: refs/heads/master@{#404062} (cherry picked from commit ef7941838399b1b0f9b7d6c2fa08337f943bb4e4)

Patch Set 1 #

Patch Set 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/chrome_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139403003/20001
4 years, 5 months ago (2016-07-13 01:36:58 UTC) #3
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 5 months ago (2016-07-13 01:37:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139403003/20001
4 years, 5 months ago (2016-07-13 01:44:35 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 01:48:56 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698