Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2123363003: Revert of Turn flag opt-in-ime-menu on by default. (Closed)

Created:
4 years, 5 months ago by Azure Wei
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Turn flag opt-in-ime-menu on by default. (patchset #2 id:20001 of https://codereview.chromium.org/2068953002/ ) Reason for revert: This feature will not be launched in M53. Original issue's description: > Turn flag: opt-in-ime-menu on by default, which aims to launch on M53. > > BUG=570761 > TEST=Verified on local build. > > Committed: https://crrev.com/8a07498f562fc6bab382e01b5e711421fa30ef72 > Cr-Commit-Position: refs/heads/master@{#400374} TBR=thestig@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=570761 Committed: https://crrev.com/ef7941838399b1b0f9b7d6c2fa08337f943bb4e4 Cr-Commit-Position: refs/heads/master@{#404062}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/chrome_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Azure Wei
Created Revert of Turn flag opt-in-ime-menu on by default.
4 years, 5 months ago (2016-07-07 01:54:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123363003/1
4 years, 5 months ago (2016-07-07 01:55:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-07 03:21:36 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-07 03:21:40 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-07 03:26:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ef7941838399b1b0f9b7d6c2fa08337f943bb4e4
Cr-Commit-Position: refs/heads/master@{#404062}

Powered by Google App Engine
This is Rietveld 408576698