Reland: Add MemoryCoordinator

Reland: Add MemoryCoordinator

Original description:

This CL adds MemoryCoordinator mojo interface and
its implementation. When --enable-features=MemoryCoordinator
is specified the browser and renderers create their
MemoryCoordinators. MemoryCoordinatorImpl (which lives in
the browser process) creates a mojo message pipe when a
renderer is launched.

This CL doesn't add actual handling of memory events, which
will be implemented in follow-up CLs.

BUG=617492
TBR=chrisha@chromium.org,haraken@chromium.org,dcheng@chromium.org,jam@chromium.org

Committed: https://crrev.com/1bb6fc3c4283aa25701f243bccb47ab97a3f6ee4
Cr-Commit-Position: refs/heads/master@{#405434}

[bashi, 2016-07-14 03:40:05]

Trying to reland.

https://codereview.chromium.org/2139363006/diff/1/content/content_tests.gypi
File content/content_tests.gypi (right):

https://codereview.chromium.org/2139363006/diff/1/content/content_tests.gypi#...
content/content_tests.gypi:1400:
'../components/components.gyp:memory_coordinator_common',
Added this line.

[bashi, 2016-07-14 03:40:12]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2016-07-14 03:40:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2016-07-14 03:43:12]

LGTM

[dcheng, 2016-07-14 03:49:33]

FWIW, it's useful to upload the original patch as PS1 when relanding. Then it's
easy for tbr reviewers to diff =)

[bashi, 2016-07-14 03:50:46]

On 2016/07/14 03:49:33, dcheng wrote:
> FWIW, it's useful to upload the original patch as PS1 when relanding. Then
it's
> easy for tbr reviewers to diff =)

Yeah, I will do that next time :)

[commit-bot: I haz the power, 2016-07-14 04:39:53]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-14 04:41:40]

Description was changed from

==========
Reland: Add MemoryCoordinator

Original description:

This CL adds MemoryCoordinator mojo interface and
its implementation. When --enable-features=MemoryCoordinator
is specified the browser and renderers create their
MemoryCoordinators. MemoryCoordinatorImpl (which lives in
the browser process) creates a mojo message pipe when a
renderer is launched.

This CL doesn't add actual handling of memory events, which
will be implemented in follow-up CLs.

BUG=617492
TBR=chrisha@chromium.org,haraken@chromium.org,dcheng@chromium.org,jam@chromiu...
==========

to

==========
Reland: Add MemoryCoordinator

Original description:

This CL adds MemoryCoordinator mojo interface and
its implementation. When --enable-features=MemoryCoordinator
is specified the browser and renderers create their
MemoryCoordinators. MemoryCoordinatorImpl (which lives in
the browser process) creates a mojo message pipe when a
renderer is launched.

This CL doesn't add actual handling of memory events, which
will be implemented in follow-up CLs.

BUG=617492
TBR=chrisha@chromium.org,haraken@chromium.org,dcheng@chromium.org,jam@chromiu...

Committed: https://crrev.com/1bb6fc3c4283aa25701f243bccb47ab97a3f6ee4
Cr-Commit-Position: refs/heads/master@{#405434}
==========

[commit-bot: I haz the power, 2016-07-14 04:41:42]

Patchset 1 (id:??) landed as
https://crrev.com/1bb6fc3c4283aa25701f243bccb47ab97a3f6ee4
Cr-Commit-Position: refs/heads/master@{#405434}

[bashi, 2016-07-14 05:20:11]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2150843002/ by bashi@chromium.org.

The reason for reverting is: Broke build again :(.

[Lei Zhang, 2016-07-14 05:34:55]

If you wait long enough, the Windows bots will be converted to GN and this
hard_dependency related problem will go away.

https://codereview.chromium.org/2139363006/diff/1/components/memory_coordinat...
File components/memory_coordinator.gypi (right):

https://codereview.chromium.org/2139363006/diff/1/components/memory_coordinat...
components/memory_coordinator.gypi:38: 'memory_coordinator_mojo_bindings',
You probably need to depend on shell_interfaces here?

[Lei Zhang, 2016-07-14 05:40:12]

https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%...
failed differently:

content_browsertests.memory_coordinator_browsertest.obj : error LNK2019:
unresolved external symbol "public: unsigned int __thiscall
memory_coordinator::MemoryCoordinator::NumChildrenForTesting(void)"
(?NumChildrenForTesting@MemoryCoordinator@memory_coordinator@@QAEIXZ) referenced
in function "protected: virtual void __thiscall
content::MemoryCoordinatorTest_HandleAdded_Test::RunTestOnMainThread(void)"
(?RunTestOnMainThread@MemoryCoordinatorTest_HandleAdded_Test@content@@MAEXXZ)

content_browsertests.memory_coordinator_browsertest.obj : error LNK2019:
unresolved external symbol "void __cdecl
memory_coordinator::EnableForTesting(void)"
(?EnableForTesting@memory_coordinator@@YAXXZ) referenced in function "public:
virtual void __thiscall content::MemoryCoordinatorTest::SetUp(void)"
(?SetUp@MemoryCoordinatorTest@content@@UAEXXZ)

[Lei Zhang, 2016-07-14 05:41:49]

On 2016/07/14 05:40:12, Lei Zhang (Slow Thursday) wrote:
>
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%...
> failed differently:

Ah, that was the first attempt. n/m.

[bashi, 2016-07-14 05:45:43]

On 2016/07/14 05:41:49, Lei Zhang (Slow Thursday) wrote:
> On 2016/07/14 05:40:12, Lei Zhang (Slow Thursday) wrote:
> >
>
https://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%...
> > failed differently:
> 
> Ah, that was the first attempt. n/m.

Thanks for the help! Second attempt is ongoing. I'll submit a try job on win as
well.