Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 2144163002: Extract client handing from ChildMemoryCoordinatorImpl (Closed)

Created:
4 years, 5 months ago by bashi
Modified:
4 years, 5 months ago
Reviewers:
haraken, chrisha
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@mc-2-notify
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract client handing from ChildMemoryCoordinatorImpl Add ClientRegistry class which becomes a base class of both MemoryCoordinator and ChildMemoryCoordinatorImpl since client registration will be the same in both coordinators. BUG=617492 Committed: https://crrev.com/ca40bc98ac6e82800ed5b3fae78bfe0a224cff5c Cr-Commit-Position: refs/heads/master@{#406725}

Patch Set 1 : fix crash #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -23 lines) Patch
M components/memory_coordinator.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/memory_coordinator/browser/memory_coordinator.h View 2 chunks +3 lines, -2 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl.h View 1 3 chunks +3 lines, -8 lines 0 comments Download
M components/memory_coordinator/child/child_memory_coordinator_impl.cc View 1 1 chunk +3 lines, -13 lines 0 comments Download
M components/memory_coordinator/common/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A components/memory_coordinator/common/client_registry.h View 1 chunk +34 lines, -0 lines 0 comments Download
A components/memory_coordinator/common/client_registry.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 24 (17 generated)
bashi
PTAL This CL depends on https://codereview.chromium.org/2139363006/
4 years, 5 months ago (2016-07-14 03:55:18 UTC) #9
haraken
LGTM
4 years, 5 months ago (2016-07-14 04:33:04 UTC) #10
chrisha
lgtm!
4 years, 5 months ago (2016-07-14 20:35:49 UTC) #13
bashi
Rebased and bots seems happy. Committing.
4 years, 5 months ago (2016-07-21 00:14:57 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144163002/40001
4 years, 5 months ago (2016-07-21 00:15:41 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 5 months ago (2016-07-21 00:21:01 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 00:24:23 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca40bc98ac6e82800ed5b3fae78bfe0a224cff5c
Cr-Commit-Position: refs/heads/master@{#406725}

Powered by Google App Engine
This is Rietveld 408576698