Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2139363005: [DevTools] Fix native function console output (Closed)

Created:
4 years, 5 months ago by kozy
Modified:
4 years, 5 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix native function console output BUG=623763 R=lushnikov@chromium.org Committed: https://crrev.com/600fbafd392e6bf2c4586b3a25a9b71932909a1a Cr-Commit-Position: refs/heads/master@{#405359}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/inspector/console/console-native-function.html View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/console/console-native-function-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
kozy
Andrey, please take a look!
4 years, 5 months ago (2016-07-13 21:57:44 UTC) #1
lushnikov
lgtm
4 years, 5 months ago (2016-07-13 22:02:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139363005/1
4 years, 5 months ago (2016-07-13 22:03:52 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 00:13:55 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-14 00:14:22 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 00:16:55 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/600fbafd392e6bf2c4586b3a25a9b71932909a1a
Cr-Commit-Position: refs/heads/master@{#405359}

Powered by Google App Engine
This is Rietveld 408576698