third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js - Issue 2139363005: [DevTools] Fix native function console output

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js

Issue 2139363005: [DevTools] Fix native function console output (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-native-function-expected.txt ('k') | third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js b/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js

index e06236f53c7579ca12b9afcc7bb7b247d54b013b..5d8ee50f648c422c0702deff234b17c8b58567be 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/ObjectPopoverHelper.js

@@ -102,7 +102,7 @@ WebInspector.ObjectPopoverHelper.prototype = {

stepInto.addEventListener("click", () => rawLocation.continueToLocation());

sectionToolbar.appendToolbarItem(stepInto);

}

- var sourceURL = rawLocation.script() ? rawLocation.script().sourceURL : null;

+ var sourceURL = rawLocation && rawLocation.script() ? rawLocation.script().sourceURL : null;

if (rawLocation && sourceURL) {

var link = this._lazyLinkifier().linkifyRawLocation(rawLocation, sourceURL);

linkContainer.appendChild(link);