Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Unified Diff: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h

Issue 2139363003: [DevTools] Cleanup v8_inspector API part 1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
index 9c649e4c46cbbe0570ba0abf833fc32f781720cc..9ef345d905d4e988e05b79d296e2feaae9cb1839 100644
--- a/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/MainThreadDebugger.h
@@ -41,6 +41,7 @@
namespace blink {
+class ConsoleMessage;
class LocalFrame;
class SecurityOrigin;
class SourceLocation;
@@ -64,6 +65,7 @@ public:
InspectorTaskRunner* taskRunner() const { return m_taskRunner.get(); }
bool isWorker() override { return false; }
+ bool isPaused() const { return m_paused; }
void setClientMessageLoop(std::unique_ptr<ClientMessageLoop>);
// TODO(dgozman): by making this method virtual, we can move many methods to ThreadDebugger and avoid some duplication. Should be careful about performance.
int contextGroupId(LocalFrame*);
@@ -71,6 +73,7 @@ public:
void contextCreated(ScriptState*, LocalFrame*, SecurityOrigin*);
void contextWillBeDestroyed(ScriptState*);
void exceptionThrown(LocalFrame*, const String& errorMessage, std::unique_ptr<SourceLocation>);
+ bool addConsoleMessage(LocalFrame*, ConsoleMessage*);
void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override;
@@ -88,6 +91,8 @@ private:
std::unique_ptr<ClientMessageLoop> m_clientMessageLoop;
std::unique_ptr<InspectorTaskRunner> m_taskRunner;
+ bool m_paused;
+ int m_muteConsoleCount;
static MainThreadDebugger* s_instance;

Powered by Google App Engine
This is Rietveld 408576698