third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp - Issue 2139363003: [DevTools] Cleanup v8_inspector API part 1.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

Issue 2139363003: [DevTools] Cleanup v8_inspector API part 1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

index 8316c404fb99f164a3f8392d6963c30007ff9d01..224fc3764a74b572650a1084180e45b9fcbd1c2b 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

@@ -466,11 +466,11 @@ std::unique_ptr<protocol::DOMDebugger::EventListener> InspectorDOMDebuggerAgent:

.setPassive(info.passive)

.setLocation(std::move(location)).build();

if (!objectGroupId.isEmpty()) {

- value->setHandler(m_v8Session->wrapObject(context, function, objectGroupId));

- value->setOriginalHandler(m_v8Session->wrapObject(context, info.handler, objectGroupId));

+ value->setHandler(m_v8Session->wrapObject(context, function, objectGroupId, false));

+ value->setOriginalHandler(m_v8Session->wrapObject(context, info.handler, objectGroupId, false));

v8::Local<v8::Function> removeFunction;

if (info.removeFunction.ToLocal(&removeFunction))

- value->setRemoveFunction(m_v8Session->wrapObject(context, removeFunction, objectGroupId));

+ value->setRemoveFunction(m_v8Session->wrapObject(context, removeFunction, objectGroupId, false));

}

return value;

}