Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Side by Side Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

Issue 2139363003: [DevTools] Cleanup v8_inspector API part 1. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 448 matching lines...) Expand 10 before | Expand all | Expand 10 after
459 std::unique_ptr<protocol::Debugger::Location> location = protocol::Debugger: :Location::create() 459 std::unique_ptr<protocol::Debugger::Location> location = protocol::Debugger: :Location::create()
460 .setScriptId(scriptId) 460 .setScriptId(scriptId)
461 .setLineNumber(lineNumber).build(); 461 .setLineNumber(lineNumber).build();
462 location->setColumnNumber(columnNumber); 462 location->setColumnNumber(columnNumber);
463 std::unique_ptr<protocol::DOMDebugger::EventListener> value = protocol::DOMD ebugger::EventListener::create() 463 std::unique_ptr<protocol::DOMDebugger::EventListener> value = protocol::DOMD ebugger::EventListener::create()
464 .setType(info.eventType) 464 .setType(info.eventType)
465 .setUseCapture(info.useCapture) 465 .setUseCapture(info.useCapture)
466 .setPassive(info.passive) 466 .setPassive(info.passive)
467 .setLocation(std::move(location)).build(); 467 .setLocation(std::move(location)).build();
468 if (!objectGroupId.isEmpty()) { 468 if (!objectGroupId.isEmpty()) {
469 value->setHandler(m_v8Session->wrapObject(context, function, objectGroup Id)); 469 value->setHandler(m_v8Session->wrapObject(context, function, objectGroup Id, false));
470 value->setOriginalHandler(m_v8Session->wrapObject(context, info.handler, objectGroupId)); 470 value->setOriginalHandler(m_v8Session->wrapObject(context, info.handler, objectGroupId, false));
471 v8::Local<v8::Function> removeFunction; 471 v8::Local<v8::Function> removeFunction;
472 if (info.removeFunction.ToLocal(&removeFunction)) 472 if (info.removeFunction.ToLocal(&removeFunction))
473 value->setRemoveFunction(m_v8Session->wrapObject(context, removeFunc tion, objectGroupId)); 473 value->setRemoveFunction(m_v8Session->wrapObject(context, removeFunc tion, objectGroupId, false));
474 } 474 }
475 return value; 475 return value;
476 } 476 }
477 477
478 void InspectorDOMDebuggerAgent::allowNativeBreakpoint(const String& breakpointNa me, const String* targetName, bool sync) 478 void InspectorDOMDebuggerAgent::allowNativeBreakpoint(const String& breakpointNa me, const String* targetName, bool sync)
479 { 479 {
480 pauseOnNativeEventIfNeeded(preparePauseOnNativeEventData(breakpointName, tar getName), sync); 480 pauseOnNativeEventIfNeeded(preparePauseOnNativeEventData(breakpointName, tar getName), sync);
481 } 481 }
482 482
483 void InspectorDOMDebuggerAgent::willInsertDOMNode(Node* parent) 483 void InspectorDOMDebuggerAgent::willInsertDOMNode(Node* parent)
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
714 m_instrumentingAgents->removeInspectorDOMDebuggerAgent(this); 714 m_instrumentingAgents->removeInspectorDOMDebuggerAgent(this);
715 } 715 }
716 } 716 }
717 717
718 void InspectorDOMDebuggerAgent::didCommitLoadForLocalFrame(LocalFrame*) 718 void InspectorDOMDebuggerAgent::didCommitLoadForLocalFrame(LocalFrame*)
719 { 719 {
720 m_domBreakpoints.clear(); 720 m_domBreakpoints.clear();
721 } 721 }
722 722
723 } // namespace blink 723 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698