Return a transparent black ImageBitmap when mailbox is invalid

Return a transparent black ImageBitmap when mailbox is invalid

In Webgl's transferToImageBitmap(), we create an ImageBitmap from the
drawingBuffer's mailbox. When calling transferToImageBitmap() twice, the
mailbox is invalid in the second call. In this case, we should return
an ImageBitmap that is the same size as the drawingBuffer but should be
transparent black.

Corresponding layout test has been updated to reflect this case.

BUG=627374
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/cf378d00d56930dabf6c4cc4d141f9f2d3803a59
Cr-Commit-Position: refs/heads/master@{#405132}

[xidachen, 2016-07-12 20:30:49]

Description was changed from

==========
Return a transparent black ImageBitmap when mailbox is invalid

In Webgl's transferToImageBitmap(), we create an ImageBitmap from the
drawingBuffer's mailbox. When calling transferToImageBitmap() twice, the
mailbox is invalid in the second call. In this case, we should return
an ImageBitmap that is the same size as the drawingBuffer but should be
transparent black.

BUG=627374
==========

to

==========
Return a transparent black ImageBitmap when mailbox is invalid

In Webgl's transferToImageBitmap(), we create an ImageBitmap from the
drawingBuffer's mailbox. When calling transferToImageBitmap() twice, the
mailbox is invalid in the second call. In this case, we should return
an ImageBitmap that is the same size as the drawingBuffer but should be
transparent black.

BUG=627374
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[xidachen, 2016-07-12 20:31:51]

Description was changed from

==========
Return a transparent black ImageBitmap when mailbox is invalid

In Webgl's transferToImageBitmap(), we create an ImageBitmap from the
drawingBuffer's mailbox. When calling transferToImageBitmap() twice, the
mailbox is invalid in the second call. In this case, we should return
an ImageBitmap that is the same size as the drawingBuffer but should be
transparent black.

BUG=627374
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Return a transparent black ImageBitmap when mailbox is invalid

In Webgl's transferToImageBitmap(), we create an ImageBitmap from the
drawingBuffer's mailbox. When calling transferToImageBitmap() twice, the
mailbox is invalid in the second call. In this case, we should return
an ImageBitmap that is the same size as the drawingBuffer but should be
transparent black.

Corresponding layout test has been updated to reflect this case.

BUG=627374
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[xidachen, 2016-07-12 20:31:51]

xidachen@chromium.org changed reviewers:
+ junov@chromium.org, kbr@chromium.org

[xidachen, 2016-07-12 20:32:23]

PTAL

[Ken Russell (switch to Gerrit), 2016-07-12 22:52:04]

lgtm

https://codereview.chromium.org/2139353003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/canvas/webgl/offscreenCanvas-transferToImageBitmap.html
(right):

https://codereview.chromium.org/2139353003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/canvas/webgl/offscreenCanvas-transferToImageBitmap.html:18:
var image2 = aCanvas.transferToImageBitmap();
Is there a test which does some work against "gl" between the fetching of image1
and image2? If not, there should be. Any drawing that is done to the
OffscreenCanvas between calls to transferToImageBitmap should show up in the
resulting ImageBitmap. The only situation where the code below should be taken
is exactly this one -- where no work is done between the calls to
transferToImageBitmap.

https://codereview.chromium.org/2139353003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2139353003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:646: // If
the mailbox is invalid, return an transparent black ImageBitmap
Could you add a comment saying that the only situation this should happen is
when two or more calls to transferToImageBitmap are made back-to-back?

[xidachen, 2016-07-12 23:46:13]

The CQ bit was checked by xidachen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 23:49:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 01:12:19]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 01:12:21]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[xidachen, 2016-07-13 12:00:37]

The CQ bit was checked by xidachen@chromium.org

[xidachen, 2016-07-13 12:00:38]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2139353003/#ps20001
(title: "address comments")

[commit-bot: I haz the power, 2016-07-13 12:00:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 12:54:49]

Description was changed from

==========
Return a transparent black ImageBitmap when mailbox is invalid

In Webgl's transferToImageBitmap(), we create an ImageBitmap from the
drawingBuffer's mailbox. When calling transferToImageBitmap() twice, the
mailbox is invalid in the second call. In this case, we should return
an ImageBitmap that is the same size as the drawingBuffer but should be
transparent black.

Corresponding layout test has been updated to reflect this case.

BUG=627374
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Return a transparent black ImageBitmap when mailbox is invalid

In Webgl's transferToImageBitmap(), we create an ImageBitmap from the
drawingBuffer's mailbox. When calling transferToImageBitmap() twice, the
mailbox is invalid in the second call. In this case, we should return
an ImageBitmap that is the same size as the drawingBuffer but should be
transparent black.

Corresponding layout test has been updated to reflect this case.

BUG=627374
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-07-13 12:54:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 12:56:27]

Description was changed from

==========
Return a transparent black ImageBitmap when mailbox is invalid

In Webgl's transferToImageBitmap(), we create an ImageBitmap from the
drawingBuffer's mailbox. When calling transferToImageBitmap() twice, the
mailbox is invalid in the second call. In this case, we should return
an ImageBitmap that is the same size as the drawingBuffer but should be
transparent black.

Corresponding layout test has been updated to reflect this case.

BUG=627374
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Return a transparent black ImageBitmap when mailbox is invalid

In Webgl's transferToImageBitmap(), we create an ImageBitmap from the
drawingBuffer's mailbox. When calling transferToImageBitmap() twice, the
mailbox is invalid in the second call. In this case, we should return
an ImageBitmap that is the same size as the drawingBuffer but should be
transparent black.

Corresponding layout test has been updated to reflect this case.

BUG=627374
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/cf378d00d56930dabf6c4cc4d141f9f2d3803a59
Cr-Commit-Position: refs/heads/master@{#405132}
==========

[commit-bot: I haz the power, 2016-07-13 12:56:51]

Patchset 2 (id:??) landed as
https://crrev.com/cf378d00d56930dabf6c4cc4d141f9f2d3803a59
Cr-Commit-Position: refs/heads/master@{#405132}