mash: Migrate //ash/system/toast to WM common types

mash: Migrate //ash/system/toast to WM common types

"Toasts" are ARC++ notifications coming from the Android side. These need
to migrate to WmWindow/WmShell so we can use them in mus.

Also make sure the toast bounds are computed based on the "target" root window
where they will appear. The existing code placed the toasts on the target root
window (which could be the secondary display), but used the primary display's
bounds for positioning.

TODO - Convert the unit test, which relies on DisplayManager for unified
desktop mode.

BUG=619636
TEST=ash_unittests, manually spawn toasts with Ctrl-Alt-Shift-O

Committed: https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230
Cr-Commit-Position: refs/heads/master@{#405181}

[James Cook, 2016-07-12 22:25:25]

Description was changed from

==========
mash: Migrate //ash/system/toast to WM common types

"Toasts" are ARC++ notifications coming from the Android side. These need
to migrate to WmWindow/WmShell so we can use them in mus.

TODO - Convert the unit test, which relies on DisplayManager for unified
desktop mode.

BUG=619636
TEST=ash_unittests, manually spawn toasts with Ctrl-Alt-Shift-O
==========

to

==========
mash: Migrate //ash/system/toast to WM common types

"Toasts" are ARC++ notifications coming from the Android side. These need
to migrate to WmWindow/WmShell so we can use them in mus.

Also make sure the toast bounds are computed based on the "target" root window
where they will appear. The existing code placed the toasts on the target root
window (which could be the secondary display), but used the primary display's
bounds for positioning.

TODO - Convert the unit test, which relies on DisplayManager for unified
desktop mode.

BUG=619636
TEST=ash_unittests, manually spawn toasts with Ctrl-Alt-Shift-O
==========

[James Cook, 2016-07-12 22:26:14]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[James Cook, 2016-07-12 22:26:31]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-07-12 22:26:31]

msw, please take a look.

[commit-bot: I haz the power, 2016-07-12 22:28:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-07-12 22:44:39]

lgtm with test file nit.

https://codereview.chromium.org/2139183003/diff/1/ash/common/system/toast/DEPS
File ash/common/system/toast/DEPS (right):

https://codereview.chromium.org/2139183003/diff/1/ash/common/system/toast/DEP...
ash/common/system/toast/DEPS:3: # TODO(jamescook): Eliminate these.
nit: maybe skip moving the test file for now? It'll be harder to track
unconverted unit test files inside common, instead of leaving them outside
common. Otherwise, perhaps add these exceptions to ash/common/DEPS, so we have a
centralized home for these exceptions, to knock them down one-by-one. (or just
cite crbug.com/619636 so we can search for that later)

[James Cook, 2016-07-12 23:30:28]

jamescook@chromium.org changed reviewers:
+ yoshiki@chromium.org

[James Cook, 2016-07-12 23:30:29]

yoshiki, can I get OWNERS for ui/arc/notification/arc_notification_manager.cc ? 
(This CL is part of the mus/mustash refactoring project.)

https://codereview.chromium.org/2139183003/diff/1/ash/common/system/toast/DEPS
File ash/common/system/toast/DEPS (right):

https://codereview.chromium.org/2139183003/diff/1/ash/common/system/toast/DEP...
ash/common/system/toast/DEPS:3: # TODO(jamescook): Eliminate these.
On 2016/07/12 22:44:39, msw wrote:
> nit: maybe skip moving the test file for now? It'll be harder to track
> unconverted unit test files inside common, instead of leaving them outside
> common. Otherwise, perhaps add these exceptions to ash/common/DEPS, so we have
a
> centralized home for these exceptions, to knock them down one-by-one. (or just
> cite crbug.com/619636 so we can search for that later)

Done. I moved it back and added it to the list of tests to convert at
http://crbug.com/620955

[James Cook, 2016-07-12 23:31:29]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 23:35:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 01:53:19]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 01:53:20]

Dry run: This issue passed the CQ dry run.

[yoshiki, 2016-07-13 04:07:34]

lgtm. Thanks!

[James Cook, 2016-07-13 16:20:04]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-07-13 16:20:05]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2139183003/#ps20001
(title: "move test back")

[commit-bot: I haz the power, 2016-07-13 16:21:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 16:26:06]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-13 16:26:21]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-13 16:28:37]

Description was changed from

==========
mash: Migrate //ash/system/toast to WM common types

"Toasts" are ARC++ notifications coming from the Android side. These need
to migrate to WmWindow/WmShell so we can use them in mus.

Also make sure the toast bounds are computed based on the "target" root window
where they will appear. The existing code placed the toasts on the target root
window (which could be the secondary display), but used the primary display's
bounds for positioning.

TODO - Convert the unit test, which relies on DisplayManager for unified
desktop mode.

BUG=619636
TEST=ash_unittests, manually spawn toasts with Ctrl-Alt-Shift-O
==========

to

==========
mash: Migrate //ash/system/toast to WM common types

"Toasts" are ARC++ notifications coming from the Android side. These need
to migrate to WmWindow/WmShell so we can use them in mus.

Also make sure the toast bounds are computed based on the "target" root window
where they will appear. The existing code placed the toasts on the target root
window (which could be the secondary display), but used the primary display's
bounds for positioning.

TODO - Convert the unit test, which relies on DisplayManager for unified
desktop mode.

BUG=619636
TEST=ash_unittests, manually spawn toasts with Ctrl-Alt-Shift-O

Committed: https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230
Cr-Commit-Position: refs/heads/master@{#405181}
==========

[commit-bot: I haz the power, 2016-07-13 16:28:38]

Patchset 2 (id:??) landed as
https://crrev.com/b6870ff8aa26f9a335aa84e54141429110035230
Cr-Commit-Position: refs/heads/master@{#405181}