ash/common/system/toast/DEPS - Issue 2139183003: mash: Migrate //ash/system/toast to WM common types

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ash/common/system/toast/DEPS

Issue 2139183003: mash: Migrate //ash/system/toast to WM common types (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 specific_include_rules = {

	2 # For unified desktop mode test.

	3 # TODO(jamescook): Eliminate these.
	msw 2016/07/12 22:44:39 nit: maybe skip moving the test file for now? It'l nit: maybe skip moving the test file for now? It'll be harder to track unconverted unit test files inside common, instead of leaving them outside common. Otherwise, perhaps add these exceptions to ash/common/DEPS, so we have a centralized home for these exceptions, to knock them down one-by-one. (or just cite crbug.com/619636 so we can search for that later) James Cook 2016/07/12 23:30:28 Done. I moved it back and added it to the list of Show quoted text On 2016/07/12 22:44:39, msw wrote: > nit: maybe skip moving the test file for now? It'll be harder to track > unconverted unit test files inside common, instead of leaving them outside > common. Otherwise, perhaps add these exceptions to ash/common/DEPS, so we have a > centralized home for these exceptions, to knock them down one-by-one. (or just > cite crbug.com/619636 so we can search for that later) Done. I moved it back and added it to the list of tests to convert at http://crbug.com/620955
	4 "toast_manager_unittest.cc": [

	5 "+ash/display/display_manager.h",

	6 "+ash/screen_util.h",

	7 "+ash/shell.h",

	8 ]

	9 }

OLD	NEW

« no previous file with comments | « ash/ash.gyp ('k') | ash/common/system/toast/OWNERS » ('j') | no next file with comments »