Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: appengine/findit/waterfall/analyze_build_failure_pipeline.py

Issue 2139093002: [Findit] Trigger swarming tasks after detech_first_faliure_pipeline (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Address comments Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/analyze_build_failure_pipeline.py
diff --git a/appengine/findit/waterfall/analyze_build_failure_pipeline.py b/appengine/findit/waterfall/analyze_build_failure_pipeline.py
index 3d0717886e83fe6476040bc2bcd60d5cac7ba8cb..701435a24eaff2a2ca8e6aef3cf5068fe76a8de0 100644
--- a/appengine/findit/waterfall/analyze_build_failure_pipeline.py
+++ b/appengine/findit/waterfall/analyze_build_failure_pipeline.py
@@ -6,6 +6,7 @@ from datetime import datetime
from common import appengine_util
from common.pipeline_wrapper import BasePipeline
+from common.pipeline_wrapper import pipeline
from model import analysis_status
from model.wf_analysis import WfAnalysis
from waterfall.detect_first_failure_pipeline import DetectFirstFailurePipeline
@@ -15,6 +16,8 @@ from waterfall.identify_culprit_pipeline import IdentifyCulpritPipeline
from waterfall.pull_changelog_pipeline import PullChangelogPipeline
from waterfall.start_try_job_on_demand_pipeline import (
StartTryJobOnDemandPipeline)
+from waterfall.trigger_swarming_tasks_pipeline import (
+ TriggerSwarmingTasksPipeline)
class AnalyzeBuildFailurePipeline(BasePipeline):
@@ -72,6 +75,11 @@ class AnalyzeBuildFailurePipeline(BasePipeline):
signals = yield ExtractSignalPipeline(failure_info)
heuristic_result = yield IdentifyCulpritPipeline(
failure_info, change_logs, deps_info, signals, build_completed)
- yield StartTryJobOnDemandPipeline(
- failure_info, signals, build_completed, force_rerun_try_job,
- heuristic_result)
+
+ with pipeline.InOrder():
+ # Trigger swarming tasks when test failure happens.
+ yield TriggerSwarmingTasksPipeline(
+ master_name, builder_name, build_number, failure_info)
+ yield StartTryJobOnDemandPipeline(
stgao 2016/07/12 20:26:52 nit: maybe add a comment here too.
chanli 2016/07/12 20:41:19 Done.
+ failure_info, signals, build_completed, force_rerun_try_job,
+ heuristic_result)

Powered by Google App Engine
This is Rietveld 408576698