appengine/findit/model/wf_analysis.py - Issue 2139093002: [Findit] Trigger swarming tasks after detech_first_faliure_pipeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/model/wf_analysis.py

Issue 2139093002: [Findit] Trigger swarming tasks after detech_first_faliure_pipeline (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Address comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | appengine/findit/waterfall/analyze_build_failure_pipeline.py » ('j') | appengine/findit/waterfall/analyze_build_failure_pipeline.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/model/wf_analysis.py

diff --git a/appengine/findit/model/wf_analysis.py b/appengine/findit/model/wf_analysis.py

index 2838adea93c03ac67cdba4ecd42d05e4cdaf226f..8401b6777ecd327f3fee0a5ec667213248dc67ed 100644

--- a/appengine/findit/model/wf_analysis.py

+++ b/appengine/findit/model/wf_analysis.py

@@ -145,7 +145,8 @@ class WfAnalysis(BaseBuildModel):

# Suspected CLs we found.

suspected_cls = ndb.JsonProperty(indexed=False, compressed=True)

# Record the id of try job results of each failure.

- failure_result_map = ndb.JsonProperty(indexed=False, compressed=True)

+ failure_result_map = ndb.JsonProperty(indexed=False, compressed=True,

+ default={})

stgao 2016/07/12 20:26:52 This possible pitfall might cause unexpected behav

chanli 2016/07/12 20:41:19 Done.

# The actual culprit CLs that are responsible for the failures.

culprit_cls = ndb.JsonProperty(indexed=False, compressed=True)

« no previous file with comments | « no previous file | appengine/findit/waterfall/analyze_build_failure_pipeline.py » ('j') | appengine/findit/waterfall/analyze_build_failure_pipeline.py » ('J')