Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2139013002: Turn off GYP by default in `gclient runhooks`. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
CC:
chromium-reviews, sdefresne, Robert Sesek, stevenjb, brucedawson
Base URL:
https://chromium.googlesource.com/chromium/src.git@flip_remaining_cros
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Turn off GYP by default in `gclient runhooks`. This CL turns off the GYP hook by default in `gclient runhooks`. While there are still some builders that use GYP, they do so explicitly in a separate step (usually by calling MB), and there is no common dev configuration where we want people to still use GYP by default, so there's no point in still running this. If you still wish to run GYP in runhooks, though, you can explicitly set GYP_CHROMIUM_NO_ACTION=0 in your environment. You can also still invoke `build/gyp_chromium` directly. R=brettw@chromium.org BUG=432967, 569975 Committed: https://crrev.com/8efd4818c9bc8e02d76401721342e618fd33d4c2 Cr-Commit-Position: refs/heads/master@{#406312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M build/gyp_chromium.py View 2 chunks +4 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (3 generated)
Dirk Pranke
!
4 years, 5 months ago (2016-07-11 22:14:36 UTC) #1
brettw
LGTM! You should probably send out an FYI to chromium-dev when this lands
4 years, 5 months ago (2016-07-11 22:33:49 UTC) #2
Dirk Pranke
On 2016/07/11 22:33:49, brettw (ping after 24h) wrote: > LGTM! You should probably send out ...
4 years, 5 months ago (2016-07-11 22:34:43 UTC) #3
Dirk Pranke
go time ...
4 years, 5 months ago (2016-07-19 17:20:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2139013002/1
4 years, 5 months ago (2016-07-19 17:20:49 UTC) #6
brettw
On 2016/07/19 17:20:49, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years, 5 months ago (2016-07-19 17:55:04 UTC) #7
Ben Goodger (Google)
lgtm !!!!
4 years, 5 months ago (2016-07-19 17:59:54 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 18:04:09 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 18:04:32 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 18:05:28 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8efd4818c9bc8e02d76401721342e618fd33d4c2
Cr-Commit-Position: refs/heads/master@{#406312}

Powered by Google App Engine
This is Rietveld 408576698